Fix issue with missing form row classes #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the issue that there are no form row classes outputted in frontend.
The source of this issue is the implementation of the widget-templates in twig. The extend-function works different here and do not use the widget-class for the $this variables in the extended php templates anymore.
This PR introduces an additional variable for the prefix with the correct variable name as used in the form row template. The better option would be the usage of html5-templates, since twig is obviously not correctly supported for widgets at this time, but that would mean a BC break. Another option would be not extending the form_row template. If you prefer my other options or find a different solution, don't hesitate to close this PR :)