Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor LD-wizard build script #178

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Refactor LD-wizard build script #178

merged 4 commits into from
Mar 4, 2024

Conversation

GerwinBosch
Copy link
Collaborator

Implements #166

This rewrite uses es-build as packager during the script

This has the following improvement

  • Build script is faster, as it no longer recompiles the LD-Wizard
  • TS is no longer required when using the package, but TS is still compiled

@GerwinBosch GerwinBosch linked an issue Mar 4, 2024 that may be closed by this pull request
Refactor LDWizard-build script to no longer fully compile the LD-Wizard #166
Closed
LaurensRietveld
LaurensRietveld reviewed Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@LaurensRietveld LaurensRietveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had 1 comment wrt the export declaration, rest looks good to me

package.json Outdated Show resolved Hide resolved
@GerwinBosch GerwinBosch merged commit b11f90a into main Mar 4, 2024
6 checks passed
@GerwinBosch GerwinBosch deleted the refactorBuildScript branch March 4, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurensRietveld LaurensRietveld Awaiting requested review from LaurensRietveld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor LDWizard-build script to no longer fully compile the LD-Wizard
2 participants
@GerwinBosch @LaurensRietveld