Using the GhAct Framework #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nleanba
reviewed
Apr 30, 2024
| Status, | ||
| STATUS_TEXT, | ||
| } from "./deps.ts"; | ||
| import frontend from "ghact/src/frontend.tsx" |
There was a problem hiding this comment.
Why is this not imported via depts.ts? This will make builds take longer and have worse caching for no apparent reason
nleanba
reviewed
Apr 30, 2024
| "imports": { | ||
| "ghact/": "https://deno.land/x/[email protected]/", | ||
| "std/": "https://deno.land/[email protected]/", | ||
| "preact": "https://esm.sh/[email protected]", |
There was a problem hiding this comment.
what is preact and why are we using it suddenly?
nleanba
reviewed
Apr 30, 2024
| "preact/": "https://esm.sh/[email protected]/" | ||
| }, | ||
| "compilerOptions": { | ||
| "jsx": "react-jsx", |
nleanba
reviewed
Apr 30, 2024
| @@ -4,247 +4,167 @@ | |||
| * The jobs are accepted as messages and stored on disk, when the worker is started uncompleted jobs are picked up and exxecuted. | |||
|
|
|||
| */ | |||
| import { existsSync, path, walk } from "./deps.ts"; | |||
| import GhactServiceWorker from "ghact/src/GhactServiceWorker.ts"; | |||
| import GitRepository from "ghact/src/GitRepository.ts"; | |||
There was a problem hiding this comment.
again, why is this not imported via depts.ts?
nleanba
reviewed
Apr 30, 2024
| import { createBadge } from "./log.ts"; | ||
| import { type Job, JobsDataBase } from "./JobsDataBase.ts"; | ||
| import { getModifiedAfter, updateLocalData } from "./repoActions.ts"; | ||
| import { type Job } from "https://deno.land/x/[email protected]/src/JobsDataBase.ts"; |
There was a problem hiding this comment.
why does this import use a different version of ghact?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.