-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jest 28 upgrade #801
Jest 28 upgrade #801
Conversation
- Adds default require for RootEnv - Adds switch if config uses Jest 28 shape
Pull Request Test Coverage Report for Build 2431421466
💛 - Coveralls |
"jest-circus": "^26.6.3 || ^27.0.0", | ||
"jest-environment-node": "^26.6.2 || ^27.0.0", | ||
"jest-runner": "^26.6.3 || ^27.0.0" | ||
"jest": "^26.6.3 || ^27.0.0 || ^28.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean after this change we are still compatible with jest 26 and 27?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tetarchus , thank you for making this PR, as we're currently blocked from upgrading jest. Do you know if this is the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because if it means we are not compatible with <28 then we need to release it as a major change, otherwise just as a minor version bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could imagine that this is full of breaking changes, as it's mentioned in the Jest 28 post that the "list of breaking changes is long". https://jestjs.io/blog/2022/04/25/jest-28
- Should now work with the existing (26/27) versions and the latest version (28)
Any news about this? |
Any plan to move forward with this upgrade? |
Upgrades to Jest 28 and fixes any test/type errors that came up.
I don't use this package directly, only through a third party library so have been unable to test in use, but all tests are successfully passing.
Please let me know if any edits need to be made, or if anything isn't working when testing in an actual use-case.
Should fix #796