Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply title rules to test.step #309

Merged
merged 5 commits into from
Sep 2, 2024

Conversation

Albinutte
Copy link
Contributor

@Albinutte Albinutte commented Aug 19, 2024

Updated valid-title rule to apply to test.step commands.

src/rules/valid-title.test.ts Show resolved Hide resolved
@Albinutte
Copy link
Contributor Author

@mskelton Thanks for the review! I addressed your comment (it was only about the first test case, right?) and pushed a tiny update to rule description.

@mskelton mskelton merged commit c689b08 into playwright-community:main Sep 2, 2024
3 checks passed
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants