fix: Ignore expect without assertion in missing-playwright-await (#…

…201)
playwright-community · Jan 18, 2024 · 47249ce · 47249ce
1 parent 5bc943f
commit 47249ce
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/rules/missing-playwright-await.ts b/src/rules/missing-playwright-await.ts
@@ -77,11 +77,11 @@ function getCallType(
   if (!expectType) return;
 
   const [lastMatcher] = getMatchers(node).slice(-1);
-  const grandparent = lastMatcher.parent.parent;
+  const grandparent = lastMatcher?.parent?.parent;
 
   // If the grandparent is not a CallExpression, then it's an incomplete
   // expect statement, and we don't need to check it.
-  if (grandparent.type !== 'CallExpression') return;
+  if (grandparent?.type !== 'CallExpression') return;
 
   const matcherName = getStringValue(lastMatcher);
 
@@ -152,6 +152,7 @@ export default {
     return {
       CallExpression(node) {
         const result = getCallType(node, awaitableMatchers);
+        console.log(result);
         const isValid = result ? checkValidity(result.node) : false;
 
         if (result && !isValid) {

diff --git a/test/spec/missing-playwright-await.spec.ts b/test/spec/missing-playwright-await.spec.ts
@@ -216,9 +216,12 @@ runRuleTester('missing-playwright-await', rule, {
     },
   ],
   valid: [
+    // Basic
     { code: test('await expect(page).toBeEditable') },
     { code: test('await expect(page).toEqualTitle("text")') },
     { code: test('await expect(page).not.toHaveText("text")') },
+    // Invalid expect calls are ignored
+    { code: 'expect.soft(page.locator("foo"))' },
     // Doesn't require an await when returning
     { code: test('return expect(page).toHaveText("text")') },
     {