chore: Convert internal build to ESM

index.cjs

@@ -0,0 +1,2 @@
+// eslint-disable-next-line @typescript-eslint/no-require-imports
+module.exports = require('./dist/index.cjs')

index.js

@@ -0,0 +1,3 @@
+import plugin from './dist/index.cjs'
+
+export default plugin

package.json

@@ -15,19 +15,20 @@
   "engines": {
     "node": ">=16.6.0"
   },
-  "type": "commonjs",
-  "types": "./index.d.mts",
+  "type": "module",
+  "types": "./index.d.ts",
   "exports": {
     ".": {
-      "types": "./index.d.mts",
-      "import": "./index.mjs",
-      "require": "./dist/index.js"
+      "types": "./index.d.ts",
+      "import": "./index.js",
+      "require": "./index.cjs"
     }
   },
   "files": [
     "dist",
-    "index.mjs",
-    "index.d.mts"
+    "index.js",
+    "index.cjs",
+    "index.d.ts"
   ],
   "scripts": {
     "build": "tsup src/index.ts --format cjs --out-dir dist",

src/index.ts

@@ -1,52 +1,52 @@
 import globals from 'globals'
-import expectExpect from './rules/expect-expect'
-import maxExpects from './rules/max-expects'
-import maxNestedDescribe from './rules/max-nested-describe'
-import missingPlaywrightAwait from './rules/missing-playwright-await'
-import noCommentedOutTests from './rules/no-commented-out-tests'
-import noConditionalExpect from './rules/no-conditional-expect'
-import noConditionalInTest from './rules/no-conditional-in-test'
-import noDuplicateHooks from './rules/no-duplicate-hooks'
-import noElementHandle from './rules/no-element-handle'
-import noEval from './rules/no-eval'
-import noFocusedTest from './rules/no-focused-test'
-import noForceOption from './rules/no-force-option'
-import noGetByTitle from './rules/no-get-by-title'
-import noHooks from './rules/no-hooks'
-import noNestedStep from './rules/no-nested-step'
-import noNetworkidle from './rules/no-networkidle'
-import noNthMethods from './rules/no-nth-methods'
-import noPagePause from './rules/no-page-pause'
-import noRawLocators from './rules/no-raw-locators'
-import noRestrictedMatchers from './rules/no-restricted-matchers'
-import noSkippedTest from './rules/no-skipped-test'
-import noStandaloneExpect from './rules/no-standalone-expect'
-import noUnsafeReferences from './rules/no-unsafe-references'
-import noUselessAwait from './rules/no-useless-await'
-import noUselessNot from './rules/no-useless-not'
-import noWaitForSelector from './rules/no-wait-for-selector'
-import noWaitForTimeout from './rules/no-wait-for-timeout'
-import preferComparisonMatcher from './rules/prefer-comparison-matcher'
-import preferEqualityMatcher from './rules/prefer-equality-matcher'
-import preferHooksInOrder from './rules/prefer-hooks-in-order'
-import preferHooksOnTop from './rules/prefer-hooks-on-top'
-import preferLocator from './rules/prefer-locator'
-import preferLowercaseTitle from './rules/prefer-lowercase-title'
-import preferNativeLocators from './rules/prefer-native-locators'
-import preferStrictEqual from './rules/prefer-strict-equal'
-import preferToBe from './rules/prefer-to-be'
-import preferToContain from './rules/prefer-to-contain'
-import preferToHaveCount from './rules/prefer-to-have-count'
-import preferToHaveLength from './rules/prefer-to-have-length'
-import preferWebFirstAssertions from './rules/prefer-web-first-assertions'
-import requireHook from './rules/require-hook'
-import requireSoftAssertions from './rules/require-soft-assertions'
-import requireToThrowMessage from './rules/require-to-throw-message'
-import requireTopLevelDescribe from './rules/require-top-level-describe'
-import validDescribeCallback from './rules/valid-describe-callback'
-import validExpect from './rules/valid-expect'
-import validExpectInPromise from './rules/valid-expect-in-promise'
-import validTitle from './rules/valid-title'
+import expectExpect from './rules/expect-expect.js'
+import maxExpects from './rules/max-expects.js'
+import maxNestedDescribe from './rules/max-nested-describe.js'
+import missingPlaywrightAwait from './rules/missing-playwright-await.js'
+import noCommentedOutTests from './rules/no-commented-out-tests.js'
+import noConditionalExpect from './rules/no-conditional-expect.js'
+import noConditionalInTest from './rules/no-conditional-in-test.js'
+import noDuplicateHooks from './rules/no-duplicate-hooks.js'
+import noElementHandle from './rules/no-element-handle.js'
+import noEval from './rules/no-eval.js'
+import noFocusedTest from './rules/no-focused-test.js'
+import noForceOption from './rules/no-force-option.js'
+import noGetByTitle from './rules/no-get-by-title.js'
+import noHooks from './rules/no-hooks.js'
+import noNestedStep from './rules/no-nested-step.js'
+import noNetworkidle from './rules/no-networkidle.js'
+import noNthMethods from './rules/no-nth-methods.js'
+import noPagePause from './rules/no-page-pause.js'
+import noRawLocators from './rules/no-raw-locators.js'
+import noRestrictedMatchers from './rules/no-restricted-matchers.js'
+import noSkippedTest from './rules/no-skipped-test.js'
+import noStandaloneExpect from './rules/no-standalone-expect.js'
+import noUnsafeReferences from './rules/no-unsafe-references.js'
+import noUselessAwait from './rules/no-useless-await.js'
+import noUselessNot from './rules/no-useless-not.js'
+import noWaitForSelector from './rules/no-wait-for-selector.js'
+import noWaitForTimeout from './rules/no-wait-for-timeout.js'
+import preferComparisonMatcher from './rules/prefer-comparison-matcher.js'
+import preferEqualityMatcher from './rules/prefer-equality-matcher.js'
+import preferHooksInOrder from './rules/prefer-hooks-in-order.js'
+import preferHooksOnTop from './rules/prefer-hooks-on-top.js'
+import preferLocator from './rules/prefer-locator.js'
+import preferLowercaseTitle from './rules/prefer-lowercase-title.js'
+import preferNativeLocators from './rules/prefer-native-locators.js'
+import preferStrictEqual from './rules/prefer-strict-equal.js'
+import preferToBe from './rules/prefer-to-be.js'
+import preferToContain from './rules/prefer-to-contain.js'
+import preferToHaveCount from './rules/prefer-to-have-count.js'
+import preferToHaveLength from './rules/prefer-to-have-length.js'
+import preferWebFirstAssertions from './rules/prefer-web-first-assertions.js'
+import requireHook from './rules/require-hook.js'
+import requireSoftAssertions from './rules/require-soft-assertions.js'
+import requireToThrowMessage from './rules/require-to-throw-message.js'
+import requireTopLevelDescribe from './rules/require-top-level-describe.js'
+import validDescribeCallback from './rules/valid-describe-callback.js'
+import validExpect from './rules/valid-expect.js'
+import validExpectInPromise from './rules/valid-expect-in-promise.js'
+import validTitle from './rules/valid-title.js'
 
 const index = {
   configs: {},
@@ -150,6 +150,8 @@ const flatConfig = {
   },
 }
 
+// @ts-expect-error We author this plugin in ESM, but export as CJS for
+// compatibility with ESLint<9. Long term, this will be changed to `export default`.
 export = {
   ...index,
   configs: {

src/rules/expect-expect.test.ts

@@ -1,5 +1,5 @@
-import rule from '../../src/rules/expect-expect'
-import { javascript, runRuleTester } from '../utils/rule-tester'
+import rule from '../../src/rules/expect-expect.js'
+import { javascript, runRuleTester } from '../utils/rule-tester.js'
 
 runRuleTester('expect-expect', rule, {
   invalid: [

src/rules/expect-expect.ts

@@ -1,7 +1,7 @@
 import ESTree from 'estree'
-import { dig } from '../utils/ast'
-import { createRule } from '../utils/createRule'
-import { parseFnCall } from '../utils/parseFnCall'
+import { dig } from '../utils/ast.js'
+import { createRule } from '../utils/createRule.js'
+import { parseFnCall } from '../utils/parseFnCall.js'
 
 export default createRule({
   create(context) {

src/rules/max-expects.test.ts

@@ -1,5 +1,5 @@
-import rule from '../../src/rules/max-expects'
-import { javascript, runRuleTester } from '../utils/rule-tester'
+import rule from '../../src/rules/max-expects.js'
+import { javascript, runRuleTester } from '../utils/rule-tester.js'
 
 runRuleTester('max-expects', rule, {
   invalid: [

src/rules/max-expects.ts

@@ -1,7 +1,7 @@
 import * as ESTree from 'estree'
-import { getParent } from '../utils/ast'
-import { createRule } from '../utils/createRule'
-import { isTypeOfFnCall, parseFnCall } from '../utils/parseFnCall'
+import { getParent } from '../utils/ast.js'
+import { createRule } from '../utils/createRule.js'
+import { isTypeOfFnCall, parseFnCall } from '../utils/parseFnCall.js'
 
 export default createRule({
   create(context) {

src/rules/max-nested-describe.test.ts

@@ -1,5 +1,5 @@
-import rule from '../../src/rules/max-nested-describe'
-import { javascript, runRuleTester } from '../utils/rule-tester'
+import rule from '../../src/rules/max-nested-describe.js'
+import { javascript, runRuleTester } from '../utils/rule-tester.js'
 
 const messageId = 'exceededMaxDepth'
 

src/rules/max-nested-describe.ts

@@ -1,6 +1,6 @@
 import * as ESTree from 'estree'
-import { createRule } from '../utils/createRule'
-import { isTypeOfFnCall } from '../utils/parseFnCall'
+import { createRule } from '../utils/createRule.js'
+import { isTypeOfFnCall } from '../utils/parseFnCall.js'
 
 export default createRule({
   create(context) {

src/rules/missing-playwright-await.test.ts

@@ -1,6 +1,6 @@
 import dedent from 'dedent'
-import rule from '../../src/rules/missing-playwright-await'
-import { javascript, runRuleTester, test } from '../utils/rule-tester'
+import rule from '../../src/rules/missing-playwright-await.js'
+import { javascript, runRuleTester, test } from '../utils/rule-tester.js'
 
 runRuleTester('missing-playwright-await', rule, {
   invalid: [

src/rules/missing-playwright-await.ts

@@ -1,8 +1,8 @@
 import { Rule } from 'eslint'
 import ESTree from 'estree'
-import { getParent, getStringValue, isIdentifier } from '../utils/ast'
-import { createRule } from '../utils/createRule'
-import { ParsedFnCall, parseFnCall } from '../utils/parseFnCall'
+import { getParent, getStringValue, isIdentifier } from '../utils/ast.js'
+import { createRule } from '../utils/createRule.js'
+import { ParsedFnCall, parseFnCall } from '../utils/parseFnCall.js'
 
 const validTypes = new Set([
   'AwaitExpression',

src/rules/no-commented-out-tests.test.ts

@@ -1,5 +1,5 @@
-import rule from '../../src/rules/no-commented-out-tests'
-import { javascript, runRuleTester } from '../utils/rule-tester'
+import rule from '../../src/rules/no-commented-out-tests.js'
+import { javascript, runRuleTester } from '../utils/rule-tester.js'
 
 const messageId = 'commentedTests'
 

src/rules/no-commented-out-tests.ts

@@ -1,6 +1,6 @@
 import { Rule } from 'eslint'
 import * as ESTree from 'estree'
-import { createRule } from '../utils/createRule'
+import { createRule } from '../utils/createRule.js'
 
 function getTestNames(context: Rule.RuleContext) {
   const aliases = context.settings.playwright?.globalAliases?.test ?? []

src/rules/no-conditional-expect.test.ts

@@ -1,5 +1,5 @@
-import rule from '../../src/rules/no-conditional-expect'
-import { javascript, runRuleTester } from '../utils/rule-tester'
+import rule from '../../src/rules/no-conditional-expect.js'
+import { javascript, runRuleTester } from '../utils/rule-tester.js'
 
 const messageId = 'conditionalExpect'
 

src/rules/no-conditional-expect.ts

@@ -1,9 +1,9 @@
 import { Rule, Scope } from 'eslint'
 import * as ESTree from 'estree'
-import { getParent, isPropertyAccessor } from '../utils/ast'
-import { createRule } from '../utils/createRule'
-import { isTypeOfFnCall, parseFnCall } from '../utils/parseFnCall'
-import { KnownCallExpression } from '../utils/types'
+import { getParent, isPropertyAccessor } from '../utils/ast.js'
+import { createRule } from '../utils/createRule.js'
+import { isTypeOfFnCall, parseFnCall } from '../utils/parseFnCall.js'
+import { KnownCallExpression } from '../utils/types.js'
 
 const isCatchCall = (
   node: ESTree.CallExpression,

src/rules/no-conditional-in-test.test.ts

@@ -1,5 +1,5 @@
-import rule from '../../src/rules/no-conditional-in-test'
-import { javascript, runRuleTester } from '../utils/rule-tester'
+import rule from '../../src/rules/no-conditional-in-test.js'
+import { javascript, runRuleTester } from '../utils/rule-tester.js'
 
 const messageId = 'conditionalInTest'
 

src/rules/no-conditional-in-test.ts

@@ -1,7 +1,7 @@
 import { Rule } from 'eslint'
-import { findParent } from '../utils/ast'
-import { createRule } from '../utils/createRule'
-import { isTypeOfFnCall } from '../utils/parseFnCall'
+import { findParent } from '../utils/ast.js'
+import { createRule } from '../utils/createRule.js'
+import { isTypeOfFnCall } from '../utils/parseFnCall.js'
 
 export default createRule({
   create(context) {

src/rules/no-duplicate-hooks.test.ts

@@ -1,5 +1,5 @@
-import rule from '../../src/rules/no-duplicate-hooks'
-import { javascript, runRuleTester } from '../utils/rule-tester'
+import rule from '../../src/rules/no-duplicate-hooks.js'
+import { javascript, runRuleTester } from '../utils/rule-tester.js'
 
 runRuleTester('basic describe block', rule, {
   invalid: [

src/rules/no-duplicate-hooks.ts

@@ -1,6 +1,6 @@
-import { getStringValue } from '../utils/ast'
-import { createRule } from '../utils/createRule'
-import { isTypeOfFnCall, parseFnCall } from '../utils/parseFnCall'
+import { getStringValue } from '../utils/ast.js'
+import { createRule } from '../utils/createRule.js'
+import { isTypeOfFnCall, parseFnCall } from '../utils/parseFnCall.js'
 
 export default createRule({
   create(context) {

src/rules/no-element-handle.test.ts

@@ -1,5 +1,5 @@
-import rule from '../../src/rules/no-element-handle'
-import { runRuleTester, test } from '../utils/rule-tester'
+import rule from '../../src/rules/no-element-handle.js'
+import { runRuleTester, test } from '../utils/rule-tester.js'
 
 runRuleTester('no-element-handle', rule, {
   invalid: [

src/rules/no-element-handle.ts

@@ -1,7 +1,7 @@
 import { AST } from 'eslint'
 import ESTree from 'estree'
-import { isPageMethod } from '../utils/ast'
-import { createRule } from '../utils/createRule'
+import { isPageMethod } from '../utils/ast.js'
+import { createRule } from '../utils/createRule.js'
 
 function getPropertyRange(node: ESTree.Node): AST.Range {
   return node.type === 'Identifier'

src/rules/no-eval.test.ts

@@ -1,5 +1,5 @@
-import rule from '../../src/rules/no-eval'
-import { javascript, runRuleTester, test } from '../utils/rule-tester'
+import rule from '../../src/rules/no-eval.js'
+import { javascript, runRuleTester, test } from '../utils/rule-tester.js'
 
 runRuleTester('no-eval', rule, {
   invalid: [

src/rules/no-eval.ts

@@ -1,5 +1,5 @@
-import { isPageMethod } from '../utils/ast'
-import { createRule } from '../utils/createRule'
+import { isPageMethod } from '../utils/ast.js'
+import { createRule } from '../utils/createRule.js'
 
 export default createRule({
   create(context) {

src/rules/no-focused-test.test.ts

@@ -1,5 +1,5 @@
-import rule from '../../src/rules/no-focused-test'
-import { runRuleTester } from '../utils/rule-tester'
+import rule from '../../src/rules/no-focused-test.js'
+import { runRuleTester } from '../utils/rule-tester.js'
 
 const messageId = 'noFocusedTest'
 

src/rules/no-focused-test.ts

@@ -1,6 +1,6 @@
-import { getStringValue } from '../utils/ast'
-import { createRule } from '../utils/createRule'
-import { parseFnCall } from '../utils/parseFnCall'
+import { getStringValue } from '../utils/ast.js'
+import { createRule } from '../utils/createRule.js'
+import { parseFnCall } from '../utils/parseFnCall.js'
 
 export default createRule({
   create(context) {

src/rules/no-force-option.test.ts

@@ -1,5 +1,5 @@
-import rule from '../../src/rules/no-force-option'
-import { runRuleTester, test } from '../utils/rule-tester'
+import rule from '../../src/rules/no-force-option.js'
+import { runRuleTester, test } from '../utils/rule-tester.js'
 
 const messageId = 'noForceOption'
 

src/rules/no-force-option.ts

@@ -1,6 +1,6 @@
 import ESTree from 'estree'
-import { getStringValue, isBooleanLiteral } from '../utils/ast'
-import { createRule } from '../utils/createRule'
+import { getStringValue, isBooleanLiteral } from '../utils/ast.js'
+import { createRule } from '../utils/createRule.js'
 
 function isForceOptionEnabled(node: ESTree.CallExpression) {
   const arg = node.arguments.at(-1)

src/rules/no-get-by-title.test.ts

@@ -1,5 +1,5 @@
-import rule from '../../src/rules/no-get-by-title'
-import { runRuleTester, test } from '../utils/rule-tester'
+import rule from '../../src/rules/no-get-by-title.js'
+import { runRuleTester, test } from '../utils/rule-tester.js'
 
 const messageId = 'noGetByTitle'
 

src/rules/no-get-by-title.ts

@@ -1,5 +1,5 @@
-import { isPageMethod } from '../utils/ast'
-import { createRule } from '../utils/createRule'
+import { isPageMethod } from '../utils/ast.js'
+import { createRule } from '../utils/createRule.js'
 
 export default createRule({
   create(context) {

src/rules/no-hooks.test.ts

@@ -1,5 +1,5 @@
-import rule from '../../src/rules/no-hooks'
-import { runRuleTester } from '../utils/rule-tester'
+import rule from '../../src/rules/no-hooks.js'
+import { runRuleTester } from '../utils/rule-tester.js'
 
 const messageId = 'unexpectedHook'