Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typing_extensions only for python<3.8 #220

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Use typing_extensions only for python<3.8 #220

merged 3 commits into from
Dec 16, 2021

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Dec 15, 2021

No description provided.

@playpauseandstop
Copy link
Owner

@q0w

Hi there!

While I understand the reasoning behind this PR, I believe it will not fix the original problem for you and typing-extensions will still be installed, while you're using rororo, as aiohttp always require it via: https://github.com/aio-libs/aiohttp/blob/68bbe75e36d691e10ced11239543ad528cf7122b/setup.cfg#L55

So, at one side I'm open to merge this to master, but from other hand typing-extensions still will be installed, but now via aiohttp dependency list.

Please let me know on your thoughts after ^

@q0w
Copy link
Contributor Author

q0w commented Dec 16, 2021

@playpauseandstop
They did it for python3.8+
aio-libs/aiohttp#5374
aio-libs/aiohttp#5912

@playpauseandstop
Copy link
Owner

playpauseandstop commented Dec 16, 2021 •
edited
Loading

@q0w

Gosh. You're completely correct. master branch of aiohttp does not mean latest code, and they for sure install typing-extenisions only for Python 3.8- in 3.8.1 version: https://github.com/aio-libs/aiohttp/blob/cc6dc0c49f5d002485f9a3cdf9bc3127a3ac1388/setup.cfg#L58

Starting process of merging this into rororo@master.

Thanks for the PR!

@playpauseandstop playpauseandstop enabled auto-merge (squash) December 16, 2021 15:21
@playpauseandstop playpauseandstop added build Changes that affect the build system or external dependencies dependencies Changes that update dependency file labels Dec 16, 2021
@coveralls
Copy link

coveralls commented Dec 16, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 98.297% when pulling e66b8f3 on q0w:patch-2 into 5328f59 on playpauseandstop:master.

@q0w
Copy link
Contributor Author

q0w commented Dec 16, 2021

Should it be through try/except ImportError or by checking python version?

@playpauseandstop
Copy link
Owner

Should it be through try/except ImportError or by checking python version?

I am fine with proposed solution, to try to import from typing and then fallback to typing_extensions.

CI is fine with that solutions as well...

@playpauseandstop playpauseandstop merged commit 1d260a0 into playpauseandstop:master Dec 16, 2021
badabump-release-bot bot pushed a commit that referenced this pull request Dec 16, 2021
@playpauseandstop
chore: 2.4.1 Release
0a03a46 
Other:
------

- (**deps**) bump actions/checkout from 2.3.5 to 2.4.0 (#218)
- (**deps**) bump actions/setup-python from 2.2.2 to 2.3.1 (#216)
- (**deps**) bump actions/cache from 2.1.6 to 2.1.7 (#214)
- (**deps**) bump tibdex/github-app-token from 1.4 to 1.5 (#215)
- (**deps**) bump peter-evans/create-pull-request from 3.10.1 to 3.11.0 (#217)
- (**deps**) bump aiohttp from 3.8.0 to 3.8.1 (#211)
- (**deps**) bump aiohttp-middlewares from 1.2.0 to 1.2.1 (#209)
- (**deps**) bump typing-extensions from 3.10.0.2 to 4.0.1 (#213)
- (**deps-dev**) bump coverage from 6.1.1 to 6.2 (#210)
- (**deps-dev**) bump types-pyyaml from 6.0.0 to 6.0.1 (#212)
- Fix link (#219)
- Install typing_extensions only for python<3.8 (#220)
@badabump-release-bot badabump-release-bot bot mentioned this pull request Dec 16, 2021
Merged
playpauseandstop added a commit that referenced this pull request Dec 16, 2021
@badabump-release-bot @playpauseandstop
chore: 2.4.1 Release (#221)
065ccf1 
Maintenance release, which in same time ensures that `rororo` installs
`typing-extensions` only for Python <3.8. Thanks @q0w for contribution.

Other:
------

- (**deps**) bump actions/checkout from 2.3.5 to 2.4.0 (#218)
- (**deps**) bump actions/setup-python from 2.2.2 to 2.3.1 (#216)
- (**deps**) bump actions/cache from 2.1.6 to 2.1.7 (#214)
- (**deps**) bump tibdex/github-app-token from 1.4 to 1.5 (#215)
- (**deps**) bump peter-evans/create-pull-request from 3.10.1 to 3.11.0 (#217)
- (**deps**) bump aiohttp from 3.8.0 to 3.8.1 (#211)
- (**deps**) bump aiohttp-middlewares from 1.2.0 to 1.2.1 (#209)
- (**deps**) bump typing-extensions from 3.10.0.2 to 4.0.1 (#213)
- (**deps-dev**) bump coverage from 6.1.1 to 6.2 (#210)
- (**deps-dev**) bump types-pyyaml from 6.0.0 to 6.0.1 (#212)
- Fix link (#219)
- Install typing_extensions only for python<3.8 (#220)

Co-authored-by: playpauseandstop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@playpauseandstop playpauseandstop playpauseandstop approved these changes

Assignees
No one assigned
Labels
build Changes that affect the build system or external dependencies dependencies Changes that update dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@q0w @playpauseandstop @coveralls