Fix integration tests on Java 11 & enforce #9188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@dwijnand this is not a fix, but I think we should backport to 2.7.x because we can then declare it Java 11 ready (since both Play and samples tests are passing). |
|
Mergify doesn't like this PR: "Base branch update has failed" once more... |
|
|
octonato
added a commit
that referenced
this pull request
Apr 19, 2019
Automatic backport of pull request #9188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The job "Run it tests for Scala 2.12 and Java 11" is failing: https://travis-ci.com/playframework/playframework/jobs/192016513
This tasks tracks fixing those issues and enforcing that it doesn't regress by removing the
allow_failuresfor Java 11.Fixes #8829