Updated dependencies and allow support for JDK 17 source #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applies changes made in playframework#1368 to revert unnecessary and incorrect changes to GroovyTemplate introduced in playframework#1338
Conflicts: framework/src/play/templates/GroovyTemplate.java
This reverts commit c151672.
tazmaniax
commented
Jan 28, 2022
tazmaniax
commented
Jan 28, 2022
Comment on lines
+199
to
+201
| // FIXME: This passes but an error is recorded that stops further testing! | ||
| // open('@{Application.jsRouteError()}') | ||
| // assertTextPresent('Wrong parameter type') |
There was a problem hiding this comment.
@xael-fry are you ok with this test being commented out? They don't pass currently and I was unable to resolve
There was a problem hiding this comment.
@tazmaniax yes as you keep it and put some comment to explain, I think we ca merge it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Helpful things
Fixes
Fixes #1366
Purpose
What does this PR do?
Updates 3rd party dependencies to the latest version and also provides support for Java 17 source code.
Background Context
Purpose
Updates 3rd party dependencies to the latest version and also provides support for Java 17 source code.
Some tests are failing, see below for details.
samples-and-tests/just-test-cases
errors.test.html
The following tests don't fail but an error is reported that stops further tests from running
routing.test.html
The following tests don't fail but an error is reported that stops further tests from running
Play 1 - ant test run 20210627.txt
samples-and-tests/nonstatic-app
See test output for exceptions
system.out.txt
References
Are there any relevant issues / PRs / mailing lists discussions?
See my previous PR on my play1 repo for discussions.