Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 17 Support #1366

Closed
willhains opened this issue Nov 9, 2021 · 11 comments · Fixed by #1372
Closed

Java 17 Support #1366

willhains opened this issue Nov 9, 2021 · 11 comments · Fixed by #1372
Milestone

Comments

@willhains
Copy link

Please add support for Java 17 (LTS).

The previous LTS release (Java 11) will end support in September 2023.

@cies
Copy link
Contributor

cies commented Nov 24, 2021

Java 14 with Play 1.6.0 is what we use, and it is the highest possible Java version afaik. I wonder what is making it impossible to use Java versions >14? Is it the dependencies, the Play1 code itself, or both?

@cies
Copy link
Contributor

cies commented Nov 24, 2021

From this PR I learned that an Eclipse JDT Core upgrade should allow Java 15.

@tomparle
Copy link
Contributor

Hi, current version of Play currently supports Java up to 16.

Support for version 17 will come, when I have some time for it unless someone else is faster :-)

@tazmaniax
Copy link
Collaborator

tazmaniax commented Nov 26, 2021

Hi, I've had a pull request on my Play1 fork that I'm running on JDK 16 on production (Heroku) and locally on JDK 17 without any issue. It only supports JDK 16 source because waiting on Eclipse JDT core update to support JDK 17. The dependencies are the latest possible as of today and all tests pass except for some "errors" and "routing" tests that I've been unable to resolve and I've commented out for the moment. I haven't raised a pull request against the main Play1 repo because I couldn't resolve these test issues and I can't vouch that won't negatively impact other applications although I haven't had any problems. Any help resolving these test issues are welcome! :)

@cies
Copy link
Contributor

cies commented Dec 6, 2021

@tazmaniax Nice set of version bumps as well!

@tazmaniax
Copy link
Collaborator

FYI my pull request now supports JDK 17 source with recent release of Eclipse JDT Core 3.28.0

@sbeigel
Copy link
Contributor

sbeigel commented Jan 19, 2022

Any news for the JDK 17 support?

@tazmaniax
Copy link
Collaborator

tazmaniax commented Jan 19, 2022

@sbeigel my pull request is working well in production with JDK 17 source code support (as of the 6th December when Eclipse JDT core v3.28.0 was released). As per my previous comment above, I have not created a pull request for the main line Play1 repo because I've had to comment out some specific tests that may not be to everyone's satisfaction and I haven't had any time to resolve them. @asolntsev @xael-fry FYI

@sbeigel
Copy link
Contributor

sbeigel commented Jan 20, 2022

I tried your code with some rather large web applications and no problems so far! Great and thank you :)

It would be great if the maintainers could chime in to get this merged soon.

Same goes btw for #1354 which makes the current master branch unusable for production.

@tazmaniax
Copy link
Collaborator

@sbeigel I've gone ahead and applied #1354 to my JDK 17 compatible Play1 pull request.

@willhains
Copy link
Author

🎉 Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants