Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings in build.sbt #588

Merged
merged 1 commit into from
Jul 15, 2021
Merged

fix warnings in build.sbt #588

merged 1 commit into from
Jul 15, 2021

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Jul 15, 2021

Pull Request Checklist

  • Have you read through the contributor guidelines?
  • Have you signed the Typesafe CLA?
  • Have you squashed your commits?
  • Have you added copyright headers to new files?
  • Have you checked that both Scala and Java APIs are updated?
  • Have you updated the documentation for both Scala and Java sections?
  • Have you added tests for any changed functionality?

Fixes

Fixes warnings

Purpose

Background Context

/home/travis/build/playframework/play-ws/build.sbt:122: warning: method copy in class AssemblyOption is deprecated (since 1.0.0): copy method is deprecated; use withIncludeBin(...) etc
  assembly / assemblyOption ~= (_.copy(includeScala = false)),
                                  ^
/home/travis/build/playframework/play-ws/build.sbt:125: warning: method copy in class AssemblyOption is deprecated (since 1.0.0): copy method is deprecated; use withIncludeBin(...) etc
    _.copy(includeScala = false)
      ^
/home/travis/build/playframework/play-ws/build.sbt:223: warning: method copy in class AssemblyOption is deprecated (since 1.0.0): copy method is deprecated; use withIncludeBin(...) etc
    assembly / assemblyOption := (assembly / assemblyOption).value.copy(includeBin = false, includeScala = false),
                                                                   ^
/home/travis/build/playframework/play-ws/build.sbt:248: warning: method copy in class AssemblyOption is deprecated (since 1.0.0): copy method is deprecated; use withIncludeBin(...) etc
    assembly / assemblyOption := (assembly / assemblyOption).value.copy(includeBin = false, includeScala = false),
                                                                   ^

References

sbt/sbt-assembly#433

```
/home/travis/build/playframework/play-ws/build.sbt:122: warning: method copy in class AssemblyOption is deprecated (since 1.0.0): copy method is deprecated; use withIncludeBin(...) etc
  assembly / assemblyOption ~= (_.copy(includeScala = false)),
                                  ^
/home/travis/build/playframework/play-ws/build.sbt:125: warning: method copy in class AssemblyOption is deprecated (since 1.0.0): copy method is deprecated; use withIncludeBin(...) etc
    _.copy(includeScala = false)
      ^
/home/travis/build/playframework/play-ws/build.sbt:223: warning: method copy in class AssemblyOption is deprecated (since 1.0.0): copy method is deprecated; use withIncludeBin(...) etc
    assembly / assemblyOption := (assembly / assemblyOption).value.copy(includeBin = false, includeScala = false),
                                                                   ^
/home/travis/build/playframework/play-ws/build.sbt:248: warning: method copy in class AssemblyOption is deprecated (since 1.0.0): copy method is deprecated; use withIncludeBin(...) etc
    assembly / assemblyOption := (assembly / assemblyOption).value.copy(includeBin = false, includeScala = false),
                                                                   ^
```
Comment on lines -124 to -126
assembly / assemblyOption ~= {
_.copy(includeScala = false)
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove duplicate setting

@mkurz mkurz merged commit 8b8133d into playframework:master Jul 15, 2021
@xuwei-k xuwei-k deleted the patch-1 branch July 15, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants