Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sbteclipse-plugin from sample apps #50

Closed
ignasi35 opened this issue Feb 28, 2019 · 4 comments
Closed

Remove sbteclipse-plugin from sample apps #50

ignasi35 opened this issue Feb 28, 2019 · 4 comments
Assignees
@ignasi35

Comments

@ignasi35
Copy link
Member

Users should handle env-specific plugins themselves.
@marcospereira marcospereira mentioned this issue Mar 25, 2019
Closed
66 tasks
This was referenced Mar 25, 2019
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Closed
Merged
Merged
@ignasi35
Copy link
Member Author

Done all the lagom-related projects I could find using sbt-eclipse.

For projects with 1.4.x and 1.5.x branches I only did 1.5.x.

In Lagom itself I sent 3 separate PRs for master, 1.5.x and 1.4.x.

@ignasi35
Copy link
Member Author

I did a quick and dirty attempt for chirper and online-auction. In case of failures or extra work, I closed the PR (we're archiving the repos anyway).

@ignasi35 ignasi35 self-assigned this Mar 25, 2019
octonato pushed a commit to lagom/lagom-scala-openshift-smoketests that referenced this issue Mar 26, 2019
@ignasi35 @octonato
Removes sbt-eclipse-plugin. Users should handle it globally on their … (
4b583c4 
#16)

…envs

See playframework/play-meta#50
octonato pushed a commit to lagom/lagom-recipes that referenced this issue Mar 26, 2019
@ignasi35 @octonato
Removes sbt-eclipse-plugin. Users should handle it globally on their …
64ed816 
…env's (#69)

See playframework/play-meta#50
This was referenced Mar 26, 2019
Merged
Merged
@dwijnand
Copy link
Member

Using GitHub search on the play, lagom and lightbend orgs I found 2 more repos (of low importance) as well as the 1.4.x branches for repos we don't intend to archive (the seeds and shopping cart). So I've backported the changes on the 1.4.x branches and PRd the other 2 repos.

This effort should be complete as soon as those PRs are merged.

Nice work, Ignasi!

dwijnand added a commit to playframework/modules.playframework.com that referenced this issue Mar 26, 2019
@dwijnand
Remove sbteclipse-plugin (#2)
9362ed3 
Eclipse users should add this as a user-wide sbt plugin instead.

Refs playframework/play-meta#50
octonato pushed a commit to lagom/lagom that referenced this issue Mar 26, 2019
@ignasi35 @octonato
[1.4.x]: Removes sbt-eclipse-plugin. Users should handle it globally …
f6af20a 
…on their … (#1824)

…envs

playframework/play-meta#50
dwijnand pushed a commit to lagom/lagom that referenced this issue Mar 26, 2019
@ignasi35 @dwijnand
[1.5.x]: Removes sbt-eclipse-plugin. Users should handle it globally …
bd85408 
…on their … (#1825)

…envs

playframework/play-meta#50
@ignasi35
Copy link
Member Author

Thanks for the final swipe @dwijnand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ignasi35 ignasi35

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dwijnand @ignasi35