Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch over dependencies to commons-email2 / Jakarta (WIP) #342

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

mikesname
Copy link
Contributor

This addresses #261 but is not yet ready for merging.

@mkurz
Copy link
Member

mkurz commented Sep 5, 2024

Thanks, I added a commit with the MiMa filters because your changes break compatibility (which is OK for a new release).
I will branch off a 10.x branch before this PR will be merged.

@mkurz
Copy link
Member

mkurz commented Sep 5, 2024

@mikesname There are tests failing now, can you please take a look, thanks!

@mikesname
Copy link
Contributor Author

@mkurz sorry, I forgot the samples. There are a few deprecation warnings I can fix if you want, but they're unrelated to this issue so I left them for now.

@mkurz mkurz merged commit a6ccece into playframework:main Oct 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants