Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace scala-collection-compat with ScalaCollectionCompat #230

Conversation

dwijnand
Copy link
Member

No description provided.

@dwijnand dwijnand force-pushed the replace-scala-collection-compat-with-ScalaCollectionCompat branch 2 times, most recently from 924d1b8 to 4ca9055 Compare January 26, 2019 10:19
@dwijnand dwijnand force-pushed the replace-scala-collection-compat-with-ScalaCollectionCompat branch from 4ca9055 to a0a085a Compare January 26, 2019 15:14
Copy link
Member

@marcospereira marcospereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marcospereira marcospereira merged commit 5b04b89 into playframework:master Jan 28, 2019
@dwijnand dwijnand deleted the replace-scala-collection-compat-with-ScalaCollectionCompat branch January 28, 2019 19:16
@marcospereira marcospereira mentioned this pull request Jan 28, 2019
6 tasks
@marcospereira
Copy link
Member

Do we need a backport to 2.7.x here?

@dwijnand
Copy link
Member Author

Yep.

marcospereira pushed a commit that referenced this pull request Jan 28, 2019
* Cleanup imports in Reads.scala

* Replace scala-collection-compat with ScalaCollectionCompat
@marcospereira
Copy link
Member

Backport to 2.7.x: 7b9da5a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants