Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the template for generating RouterUsingActions #293

Closed
wants to merge 1 commit into from
Closed

Fix the template for generating RouterUsingActions #293

wants to merge 1 commit into from

Conversation

drZoid
Copy link
Contributor

@drZoid drZoid commented Aug 31, 2020

  1. Modified the error handler type to ActorSystem => PartialFunction[Throwable, Trailers]
  2. Removed the extra materializer being passed to ServiceHandler.

This fixes issue for play-grpc version 0.8.2

@lightbend-cla-validator
Copy link

Hi @drZoid,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@drZoid drZoid closed this Aug 31, 2020
@drZoid drZoid deleted the fix/RouterUsingActions branch August 31, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drZoid @lightbend-cla-validator