Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] fix TestPlayer test helper dependency #83

Merged
merged 2 commits into from
Sep 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ open class BaseAssetRegistry<WrapperType>: PlayerRegistry where
}

public struct RegistryDecodeShim<Asset>: Decodable {
let asset: Asset
public let asset: Asset

public init(from decoder: Decoder) throws {
let decodeFunction: DecodeAssetFunction<Asset> = try decoder.getDecodeAssetFunction()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ A wrapper around the JS DataController in the core player
open class BaseDataController {

/// The JSValue that backs this wrapper
let value: JSValue
public let value: JSValue

/**
Construct a DataController from a JSValue
Expand Down
2 changes: 1 addition & 1 deletion ios/packages/core/Sources/utilities/JSUtilities.swift
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public class JSUtilities {
- parameters:
- context: The context to polyfill
*/
static func polyfill(_ context: JSContext) {
public static func polyfill(_ context: JSContext) {
let setTimeout: @convention(block) (JSValue?, JSValue?) -> Void = { (function, timeout) in
guard let function = function, let timeout = timeout?.toInt32() else { return }
DispatchQueue
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import Foundation
import XCTest
import JavaScriptCore

extension JSContext {
Expand Down