Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to migrate material to default to physical v1 #7100

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented Nov 7, 2024

  • Sets Engine V1 material to default to physical

@kpal81xd kpal81xd self-assigned this Nov 7, 2024
@kpal81xd kpal81xd added the bug label Nov 7, 2024
@kpal81xd kpal81xd requested review from mvaligursky and a team November 7, 2024 18:56
Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, so a missing shaderModel is the problem as the data.shader was removed on the Editor side right?

@kpal81xd
Copy link
Contributor Author

kpal81xd commented Nov 8, 2024

looks good, so a missing shaderModel is the problem as the data.shader was removed on the Editor side right?

Yea all materials were assumed to be Phong so this fixes the issue

@kpal81xd kpal81xd merged commit 79ad1d6 into main_v1 Nov 8, 2024
8 checks passed
mvaligursky pushed a commit that referenced this pull request Nov 12, 2024
* Updated material to default to physical

* Moved delete inside if
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants