Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gsplat example shaders to latest structure #7021

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Update gsplat example shaders to latest structure #7021

merged 1 commit into from
Oct 10, 2024

Conversation

slimbuck
Copy link
Member

Also change a shader variable name (sampler -> s) which was causing WebGPU transpile step to fail.

@slimbuck slimbuck added bug area: graphics Graphics related issue labels Oct 10, 2024
@slimbuck slimbuck requested a review from a team October 10, 2024 09:41
@slimbuck slimbuck self-assigned this Oct 10, 2024
@slimbuck slimbuck merged commit 154ca8d into playcanvas:main Oct 10, 2024
7 of 8 checks passed
@slimbuck slimbuck deleted the gsplat-shader-fixes branch October 10, 2024 09:53
slimbuck added a commit to slimbuck/engine that referenced this pull request Nov 5, 2024
@slimbuck
Update gsplat example shaders to latest structure (playcanvas#7021)
3ed3d55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

Assignees

@slimbuck slimbuck

Labels
area: graphics Graphics related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slimbuck @mvaligursky