Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to non-clustered omni light shadows #6998

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Improvements to non-clustered omni light shadows #6998

merged 3 commits into from
Oct 1, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Sep 30, 2024 •
edited
Loading

  • removed webgl1 based omni shadows that were encoding depth in the RGBA8, and using depth buffer instead
  • swapped 9 sample based omni PCF3x3 but more optimized 4 sample based
  • bunch fo cleanup of the related shadow code
  • added PCF1 support to omni shadows

@mvaligursky mvaligursky self-assigned this Sep 30, 2024
@mvaligursky mvaligursky added performance Relating to load times or frame rate area: graphics Graphics related issue enhancement labels Sep 30, 2024
@mvaligursky mvaligursky requested a review from a team September 30, 2024 15:13
willeastcott
willeastcott approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely simplification

@mvaligursky mvaligursky merged commit 93fd826 into main Oct 1, 2024
8 checks passed
@mvaligursky mvaligursky deleted the mv-omni-shadows branch October 1, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement performance Relating to load times or frame rate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvaligursky @willeastcott @slimbuck