RenderPassCameraFrame exposes HDR formats #6969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mvaligursky
commented
Sep 19, 2024
•
mvaligursky
commented
- this allows the users to specify preference of the HDR format used for rendering
- also, when no HDR format is supported, the bloom is automatically disabled as non-supported
marklundin
approved these changes
Sep 19, 2024
Comment on lines
+149
to
+152
| const arraysNotEqual = (arr1, arr2) => arr1 !== arr2 && | ||
| (!(Array.isArray(arr1) && Array.isArray(arr2)) || | ||
| arr1.length !== arr2.length || | ||
| !arr1.every((value, index) => value === arr2[index])); |
There was a problem hiding this comment.
Did you forget about this:
https://github.com/playcanvas/engine/blob/main/src/core/array-utils.js#L4
There was a problem hiding this comment.
I spent few minutes looking for this and didn't find it .. I though I removed it in 2.0 :)
Will adjust, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.