Fix trigger crash #6926
Merged
Fix trigger crash #6926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
reviewed
Sep 8, 2024
use indexOf Co-authored-by: Will Eastcott <[email protected]>
willeastcott
reviewed
Sep 8, 2024
=) Co-authored-by: Will Eastcott <[email protected]>
willeastcott
approved these changes
Sep 8, 2024
|
For some reason, when I originally was writing it, indexOf was returning me -1, so I went with |
|
@LeXXik I've tweaked the code to make |
|
@willeastcott looks good. Even though removing a body from world if it is not there should be "safe", there is no harm in additional check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2572
Prevents adding a trigger to the dynamics world, if it is already there.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.