WebGPU partial support for multisampled RT using supplied depth texture #6917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mvaligursky
commented
Sep 6, 2024
•
mvaligursky
commented
- implements support for WebGPU rendering to a supplied depth texture when MSAA is enabled. This internally allocates additional MSAA depth buffer for rendering.
- refactored to store depth related parts of WegpuRenderTarget in a DepthAttachment private class
- solves first point here: WebGPU MSAA render target with depth buffer fails #5714 (comment)
- other points to be done separately
willeastcott
reviewed
Sep 6, 2024
| @@ -12,6 +12,8 @@ const stringIds = new StringIds(); | |||
|
|
|||
| /** | |||
| * Private class storing info about color buffer. | |||
| * | |||
| * @private | |||
There was a problem hiding this comment.
I'm guessing this is unnecessary because the root index.js does not export this class.
There was a problem hiding this comment.
yeah but I had to add it to avoid the type errors coming from WebGPU types
willeastcott
reviewed
Sep 6, 2024
| * A WebGPU implementation of the RenderTarget. | ||
| * Private class storing info about depth-stencil buffer. | ||
| * | ||
| * @private |
willeastcott
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.