Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for assigning properties to script instances #6787

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

marklundin
Copy link
Member

@marklundin marklundin commented Jul 5, 2024

This PR adds a properties field to the scripts.create(name, { properties }) which is used to assign values onto a script instance before initialize() is called.

Fixes #6785

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Copy link
Contributor

@mvaligursky mvaligursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great to add an example to Script class module on how to use this.

@marklundin marklundin merged commit e20814a into main Aug 30, 2024
8 checks passed
@marklundin marklundin deleted the script-create-properties branch August 30, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a ESM Script with attributes
3 participants