Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESM Multi camera #6642

Merged
merged 19 commits into from
Oct 29, 2024
Merged

ESM Multi camera #6642

merged 19 commits into from
Oct 29, 2024

Conversation

kpal81xd
Copy link
Contributor

@kpal81xd kpal81xd commented May 30, 2024 •
edited
Loading

  • Added base camera ESM script
  • Added multi-camera ESM script which extends base camera
  • Added example for multi-camera and controls for attributes

Preview

image

@kpal81xd kpal81xd self-assigned this May 30, 2024
@kpal81xd kpal81xd marked this pull request as draft May 30, 2024 09:34
@LeXXik
Copy link
Contributor

LeXXik commented May 30, 2024

What is the example's name? I can't seem to find it in the preview.

@kpal81xd
Copy link
Contributor Author

What is the example's name? I can't seem to find it in the preview.

Its currently hidden as its not complete yet

@kpal81xd kpal81xd changed the title Added Multicamera ESM Multi camera Oct 28, 2024
@kpal81xd kpal81xd marked this pull request as ready for review October 28, 2024 16:56
@kpal81xd kpal81xd requested a review from a team October 28, 2024 16:57
@kpal81xd kpal81xd mentioned this pull request Oct 29, 2024
Closed
willeastcott
willeastcott approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear and concise implementation - very nice! 👏

@kpal81xd kpal81xd merged commit ff5ab64 into main Oct 29, 2024
8 checks passed
@kpal81xd kpal81xd deleted the script-cameras branch October 29, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@kpal81xd kpal81xd

Labels
area: examples area: scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpal81xd @LeXXik @willeastcott