[BREAKING] Remove support for legacy scripts #6584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mvaligursky
commented
May 22, 2024
mvaligursky
commented
- removed support for long time deprecated and disabled scripting system
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I guess we can remove I'm not 100% certain, but I never used it and quick code search only seems to be related to legacy system: https://github.com/search?q=%22pc.script.attribute%28%22&type=code |
willeastcott
changed the title
yep, gone now, thanks |
kpal81xd
approved these changes
May 22, 2024
# Conflicts: # src/framework/application.js
|
Tested against a project with the legacy scripts, and we get no crashes from it, the behaviour is the same as before removing the component. |
22 tasks
marklundin
pushed a commit
that referenced
this pull request
Jun 6, 2024
* [BREAKING] Remove support for legaxy scripts * removed pc.script.attribute --------- Co-authored-by: Martin Valigursky <[email protected]>
marklundin
added a commit
that referenced
this pull request
Jun 18, 2024
* refactored script type * removed attribute check on esm scripts * linting fixes * Delete redundant scripts * Remove engines field from package-lock.json * Fix event name in ScriptType class * Add export to rawToValue function and update script schema in ScriptHandler * linting * Update script attribute assignment in ScriptComponent * Fix script initialization and enablement * Fix missing semicolon in ScriptRegistry class * Refactor script component and handler * GS reorder fix (#6410) * USDZ / GLTF exporter supports exposing of compressed textures on WebGPU (#6394) * Support for Picker on WebGPU * Gizmos example on webgpu * USDZ / GLTF exporter supports exposing of compressed textures on WebGPU * tiny comment update --------- Co-authored-by: Martin Valigursky <[email protected]> * restore default color when setting axis shape disable to false (#6587) * [Fix] Add missing exposure handling from the Neutral tonemapping (#6592) * SSAO engine example (#6586) * SSAO engine example * lint * draco + texture resize: 17MB -> 6MB --------- Co-authored-by: Martin Valigursky <[email protected]> * [BREAKING] Removed backwards compatibility for few functions (#6408) * [BREAKING] Removed backwards compatibility for few functions * lint --------- Co-authored-by: Martin Valigursky <[email protected]> * Examples app bundle optimizations (#6588) * treeshake smallest enabled * ignore playcanvas PCUI from being treeshaken * treeshake ignore only pcui * added device type constants directly (no playcanvas dependency) * format rollup * word wrap fix * Updated PCUI * removed PCUI aliasing * Fix to just submitted AO example to disabled baked in occlusion maps (#6593) Co-authored-by: Martin Valigursky <[email protected]> * added publint to ci; removed build:publish (#6363) * Fix types for calcAabb functions (#6596) * vercel setup (#6600) * replaces slashes for windows (#6601) * fixed using query params with iframe example (#6604) * New texture formats: R8 and RG8 (#6602) * New texture formats: R8 and RG8 * Apply suggestions from code review Co-authored-by: Will Eastcott <[email protected]> * deprecate the old constants --------- Co-authored-by: Martin Valigursky <[email protected]> Co-authored-by: Will Eastcott <[email protected]> * Added orthogonal facing translation to gizmo (#6607) * set shader chunk type to record (#6621) * Gizmo example update (#6622) * separated out grid code * split out selector and disabled deselection on orbiting * added type for observer set callback * fixed example page * Exports and types fixes (#6623) * cleaned up ts and js config; adds debug and profiler to exports * set module resolution to node * added package json for linting of example modules and renamed @examples to examples * PR commit (#6626) * fixed fallback options (#6628) * fixed example types (#6634) * fixed selection bug (#6637) * Fix URL handling in ScriptHandler (#6639) * Fix mesh collider creation (#6630) * Docs update (#6631) * docs update * Update README.md --------- Co-authored-by: Will Eastcott <[email protected]> * Update script component to use getSchema method instead of tSchema * Refactor script component attribute initialization * merge fix * linting * Update import statement in script.js * Refactor script attribute assignment * linting * Refactor script component initialization * Refactor script component and script handler * linting + comments * Fix the definition of sheenTint Standard Material property (#6665) Co-authored-by: Martin Valigursky <[email protected]> * Update to skybox shader to map it closer to the infinity (#6664) Co-authored-by: Martin Valigursky <[email protected]> * [Fix] Particle system handle different IB formats of incoming mesh (#6662) Co-authored-by: Martin Valigursky <[email protected]> * [BREAKING] Remove deprecated AudioSourceComponent component (#6407) Co-authored-by: Martin Valigursky <[email protected]> * Cubemap fix for webgpu (#6669) * [BREAKING] Remove support for legacy scripts (#6584) * [BREAKING] Remove support for legaxy scripts * removed pc.script.attribute --------- Co-authored-by: Martin Valigursky <[email protected]> * Fix shader chunk error for tonemapped compressed GS (#6670) * Remove support for legacy scripts * Remove legacy script system * Add getScriptName function and toLowerCamelCase utility function * jsdoc improvements * Update src/framework/script/script.js Co-authored-by: Will Eastcott <[email protected]> * Update src/framework/script/script-attributes.js Co-authored-by: Will Eastcott <[email protected]> * linting + feedback * Update src/framework/script/script.js Co-authored-by: Will Eastcott <[email protected]> * removed redundant error link * Update src/framework/script/script.js Co-authored-by: Will Eastcott <[email protected]> * Update src/framework/script/script.js Co-authored-by: Will Eastcott <[email protected]> * Update src/framework/script/script.js Co-authored-by: Will Eastcott <[email protected]> * Update src/framework/script/script-attributes.js Co-authored-by: Will Eastcott <[email protected]> * Update src/framework/script/script-type.js Co-authored-by: Will Eastcott <[email protected]> * Update src/framework/components/script/component.js Co-authored-by: Will Eastcott <[email protected]> * Refactor attributeToValue function --------- Co-authored-by: Donovan Hutchence <[email protected]> Co-authored-by: Martin Valigursky <[email protected]> Co-authored-by: Martin Valigursky <[email protected]> Co-authored-by: KPal <[email protected]> Co-authored-by: Will Eastcott <[email protected]> Co-authored-by: kpal81xd <[email protected]> Co-authored-by: Alex <[email protected]> Co-authored-by: Will Eastcott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.