WebGL device ignores WebGL1 request and always creates WebGL2 device #6297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mvaligursky
commented
Apr 26, 2024
•
mvaligursky
commented
- WebGL device ignores WebGL1 request and always creates WebGL2 device
|
Prob worth still add a description? |
kpal81xd
approved these changes
Apr 26, 2024
kpal81xd
reviewed
Apr 26, 2024
yaustar
reviewed
Apr 26, 2024
| @@ -21,9 +21,7 @@ const createApp = async function (deviceType) { | |||
| device = new pc.WebgpuGraphicsDevice(canvas, {}); | |||
| await device.initWebGpu(rootPath + '/static/lib/glslang/glslang.js', rootPath + '/static/lib/twgsl/twgsl.js'); | |||
| } else if (deviceType === 'webgl1' || deviceType === 'webgl2') { | |||
| device = new pc.WebglGraphicsDevice(canvas, { | |||
There was a problem hiding this comment.
Do we want to add a warning if webgl1 is requested saying deprecated or something?
There was a problem hiding this comment.
No really, we'll string it out from examples completely so it cannot be requested by the examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.