Comparisons pagination fixes #4697
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles the case where main query has a limit and results change. Doesnt handle metrics like percentage.
Only to be used in testing
macobo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Depends on #4692
Currently, when doing comparisons when breaking down by e.g.
visit:browserdimension, zeroes would be incorrectly applied when small limits are in place. This is because the top 10 browsers today might not be the same as in previous period.This PR fixes that by OR-ing together all dimension values from main result in comparison filter. Additionally, this filter is ignored when calculating totals as is needed for percentage/conversion rate calculations.
Rather than test every old endpoint separately, this PR adds a test-only endpoint for testing query logic as well.