move site imports migration to clickhouse repo #4316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing in favor of "global" ordering of pending migrations: #4466 |
ruslandoga
deleted the
move-site-imports-migration-to-clickhouse-repo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When upgrading from v2.0.0 to v2.1.1 site_imports data migration fails because
import_idcolumns are missing from ClickHouse tables at the time of the migration. This happens because PostgreSQL migrations run before ClickHouse migrations that add import_id columns. This PR moves site_imports data migration from PostgreSQL migrations to Clickhouse migrations.Converting this to Draft to test the following scenarios:
Reviews are still welcome!
Tests
Changelog
Documentation
Dark mode