Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser icons #4239

Merged
merged 6 commits into from
Jun 18, 2024
Merged

Add browser icons #4239

merged 6 commits into from
Jun 18, 2024

Conversation

ukutaht
Copy link
Contributor

@ukutaht ukutaht commented Jun 17, 2024

Changes

Adds icons for popular browsers, including a fallback for when we don't have an icon (ex: Android Browser below)

Screenshot 2024-06-17 at 16 57 28

Tests

  • This PR does not require tests

Changelog

  • [c] Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode

'Chrome': 'chrome.svg',
'Safari': 'safari.svg',
'Firefox': 'firefox.svg',
'Edge': 'edge.svg',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't that one "Microsoft Edge"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes. The seeds misled me, I've fixed them here: f8b4a4e

@ukutaht ukutaht merged commit 0060954 into master Jun 18, 2024
10 checks passed
@ukutaht ukutaht deleted the add-browser-icons branch June 18, 2024 09:45
@ukutaht ukutaht mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants