Revert "WIP: 404 tracking wizard"

This reverts commit a9c9c79.
plausible · Aug 28, 2024 · 3ba8167 · 3ba8167
1 parent a9c9c79
commit 3ba8167
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 91 deletions.
diff --git a/lib/plausible/goals/goals.ex b/lib/plausible/goals/goals.ex
@@ -248,12 +248,6 @@ defmodule Plausible.Goals do
     :ok
   end
 
-  @spec create_404(Plausible.Site.t()) :: :ok
-  def create_404(%Plausible.Site{} = site) do
-    create(site, %{"event_name" => "404"}, upsert?: true)
-    :ok
-  end
-
   @spec delete_outbound_links(Plausible.Site.t()) :: :ok
   def delete_outbound_links(%Plausible.Site{} = site) do
     q =
@@ -276,17 +270,6 @@ defmodule Plausible.Goals do
     :ok
   end
 
-  @spec delete_404(Plausible.Site.t()) :: :ok
-  def delete_404(%Plausible.Site{} = site) do
-    q =
-      from g in Goal,
-        where: g.site_id == ^site.id,
-        where: g.event_name == "404"
-
-    Repo.delete_all(q)
-    :ok
-  end
-
   defp insert_goal(site, params, upsert?) do
     params = Map.delete(params, "site_id")
 

diff --git a/lib/plausible_web/live/installation.ex b/lib/plausible_web/live/installation.ex
@@ -14,8 +14,7 @@ defmodule PlausibleWeb.Live.Installation do
     "file-downloads",
     "hash",
     "pageview-props",
-    "revenue",
-    "404"
+    "revenue"
   ]
 
   @installation_types [
@@ -227,28 +226,10 @@ defmodule PlausibleWeb.Live.Installation do
     """
   end
 
-  defp render_snippet("manual", domain, %{"404" => true} = script_config) do
-    script_config = Map.put(script_config, "404", false)
-
-    """
-    #{render_snippet("manual", domain, script_config)}
-    #{render_snippet_404("manual")}
-    """
-  end
-
   defp render_snippet("manual", domain, script_config) do
     ~s|<script defer data-domain="#{domain}" src="#{tracker_url(script_config)}"></script>|
   end
 
-  defp render_snippet("GTM", domain, %{"404" => true} = script_config) do
-    script_config = Map.put(script_config, "404", false)
-
-    """
-    #{render_snippet("GTM", domain, script_config)}
-    #{render_snippet_404("GTM")}
-    """
-  end
-
   defp render_snippet("GTM", domain, script_config) do
     """
     <script>
@@ -262,14 +243,6 @@ defmodule PlausibleWeb.Live.Installation do
     """
   end
 
-  def render_snippet_404("manual") do
-    "<script>window.plausible = window.plausible || function() { (window.plausible.q = window.plausible.q || []).push(arguments) }</script>"
-  end
-
-  def render_snippet_404("GTM") do
-    render_snippet_404("manual")
-  end
-
   defp script_extension_control(assigns) do
     ~H"""
     <div class="mt-2 p-1">
@@ -365,13 +338,6 @@ defmodule PlausibleWeb.Live.Installation do
         tooltip="Assign monetary values to purchases and track revenue attribution. Additional action required."
         learn_more="https://plausible.io/docs/ecommerce-revenue-tracking"
       />
-      <.script_extension_control
-        config={@script_config}
-        variant="404"
-        label="404 errors"
-        tooltip="Automatically track 404 error pages. Additional action required."
-        learn_more="https://plausible.io/docs/error-pages-tracking-404"
-      />
     </form>
     """
   end
@@ -446,16 +412,6 @@ defmodule PlausibleWeb.Live.Installation do
     update_script_config(socket, %{key => false})
   end
 
-  defp update_script_config(socket, "404" = key, true) do
-    Plausible.Goals.create_404(socket.assigns.site)
-    update_script_config(socket, %{key => true})
-  end
-
-  defp update_script_config(socket, "404" = key, false) do
-    Plausible.Goals.delete_404(socket.assigns.site)
-    update_script_config(socket, %{key => false})
-  end
-
   defp update_script_config(socket, key, value) do
     update_script_config(socket, %{key => value})
   end

diff --git a/test/plausible_web/live/installation_test.exs b/test/plausible_web/live/installation_test.exs
@@ -183,31 +183,7 @@ defmodule PlausibleWeb.Live.InstallationTest do
       end
     end
 
-    test "allows manual snippet customization with 404 links", %{conn: conn, site: site} do
-      {lv, _html} = get_lv(conn, site, "?installation_type=manual")
-
-      lv
-      |> element(~s|form#snippet-form|)
-      |> render_change(%{
-        "404" => "on"
-      })
-
-      html = lv |> render()
-
-      assert text_of_element(html, "textarea#snippet") =~
-               "function() { (window.plausible.q = window.plausible.q || []).push(arguments) }&amp;lt;/script&amp;gt;"
-
-      lv
-      |> element(~s|form#snippet-form|)
-      |> render_change(%{})
-
-      html = lv |> render()
-
-      refute text_of_element(html, "textarea#snippet") =~
-      "function() { (window.plausible.q = window.plausible.q || []).push(arguments) }&amp;lt;/script&amp;gt;"
-    end
-
-    test "turning on file-downloads, outbound-links and 404 creates special goals", %{
+    test "turning on file-downloads and outbound-links creates special goals", %{
       conn: conn,
       site: site
     } do
@@ -219,16 +195,14 @@ defmodule PlausibleWeb.Live.InstallationTest do
       |> element(~s|form#snippet-form|)
       |> render_change(%{
         "file-downloads" => "on",
-        "outbound-links" => "on",
-        "404" => "on"
+        "outbound-links" => "on"
       })
 
       lv |> render()
 
-      assert [clicks, downloads, error_404] = Plausible.Goals.for_site(site)
+      assert [clicks, downloads] = Plausible.Goals.for_site(site)
       assert clicks.event_name == "Outbound Link: Click"
       assert downloads.event_name == "File Download"
-      assert error_404.event_name == "404"
     end
 
     test "turning off file-downloads and outbound-links deletes special goals", %{