Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volunteer collaborators are needed #123

Open
platosha opened this issue Jan 30, 2017 · 20 comments
Open

Volunteer collaborators are needed #123

platosha opened this issue Jan 30, 2017 · 20 comments

Comments

@platosha
Copy link
Owner

We are looking for collaborators to work on this project. If you want to become a collaborator, please leave a comment below.

Collaborator responsibilities include:

  • Responding to issues
  • Reviewing and merging pull requests
  • Development contributions: add features, fix bugs
platosha added a commit that referenced this issue Jan 30, 2017
@BorntraegerMarc
Copy link
Collaborator

I think we are already in contact :)

@MarkPieszak
Copy link
Collaborator

@platosha Is there a Slack channel or anything we can all talk in?
Maybe we can make a channel in the Polymer Slack?

But yes, definitely would like to help out!
Do you have a design doc or anything about how it's all put together currently, wanted to see if any private pieces of Core we're touching will be affected in 4.x in March. @platosha

@BorntraegerMarc
Copy link
Collaborator

Good idea. I was in the process of creating an own https://angular-polymer.slack.com. What makes more sense? To integrate in the existing polymer slack or a new one? In my opinion to get a channel in the existing polymer slack would be a bit better...

Friendly ping to @platosha :)

@MarkPieszak
Copy link
Collaborator

I think we should stay close to Polymer, we might as well be in there.

@BorntraegerMarc
Copy link
Collaborator

Agreed. I've already made a request in their slack for an own channel. I hope it's possible...

@platosha
Copy link
Owner Author

platosha commented Feb 8, 2017

Works for me.

If using Polymer Slack is not possible, I would prefer to create a Gitter chat over Slack then. I like the gitter UI more, and also the webcomponents.org community chat is there.

@platosha
Copy link
Owner Author

platosha commented Feb 8, 2017

@MarkPieszak We don’t have a design doc yet.

In short, pretty much all the current implementation is in the single file src/polymer-element.ts, and most of the job is done by the exported PolymerElement(name: string) function. The idea there is simple: it takes an element name from the argument, extracts the element’s prototype, generates a few directives based on the prototype, and returns them.

The only private part was BrowserDomAdapter, as far as I remember. As you probably know, the related part has already stopped working, and the renderer replacement is coming up.

@MarkPieszak
Copy link
Collaborator

Perfect yeah let me take a look at the implementation to see where I can help out!

@manekinekko
Copy link

manekinekko commented Feb 12, 2017

Hi. I would like to help out. Btw, have you seen this interop work https://github.com/webcomponents/angular-interop?

@MarkPieszak
Copy link
Collaborator

Wassim! Now it's a party 🍻

@BorntraegerMarc
Copy link
Collaborator

@manekinekko Never seen it but seems cool. Did you try it for production use? And how does it differ to this implementation?

@manekinekko
Copy link

@MarkPieszak haha! good to see you here. I'm glad Michael Prentice sent me here ^^

@BorntraegerMarc the interop implementation is straightforward. My goal was to use vanilla Polymer with raw Angular (>=2) without any glue code (or at as little as possible). So this interop repo tries to serve as an implementation reference. It's not a library.

FYI, I've also implemented another interop repo for Web Components (v0 spec) here: https://github.com/manekinekko/angular-wc-interop

I'm was wondering what made you create this library?

PS: I'm OK to continue this discussion on slack/gitter.

@MarkPieszak
Copy link
Collaborator

2 way binding with polymer mainly. @platosha could answer that best

@Splaktar
Copy link
Contributor

It also does some work to hook up Form events and inputs with Polymer web components. In the past, it has had issues with accessing the window object to get window.Polymer which doesn't play well with Universal. So in addition to switching to the new Renderer interface, it would be nice to get it working with Universal.

@MarkPieszak
Copy link
Collaborator

@Splaktar Yeah definitely, we want it to play well with Universal/web-workers for sure. I talked with @platosha the other day so I started looking into a few things to get everything going to get the project up to date with everything.

We'll be switching everything to use the Renderer
At the very least just ignore window.Polymer and bail out if it doesn't exist, so we won't be able to render anything on the server, but at least it'll appear on the client later.
The other main issue is AoT since you can't have functions like PolymerElement()

Maybe we can all meet up sometime next week?
Anton and I have been talking in the Polymer slack if you guys are in there, think he's trying to get a channel for this as well.

@Splaktar
Copy link
Contributor

I'm in the Polymer Slack, but I can't keep up with things in general. A specific channel would be really helpful.

@BorntraegerMarc
Copy link
Collaborator

We just got the https://polymer.slack.com/messages/polymer-angular/ channel :)

@malkomich
Copy link

I would like to contribute to this project.

Can anyone tell me how to begin? Any straightforward issue to start working on it?

@rjcorwin
Copy link

@manekinekko Unfortunately that example is out of date.

I think they need to upgrade to Polymer 2 and base the example on Angular CLI.

@ZiruZanrgeiff
Copy link

Hello guys i would like to contribute. Nowadays I am using this component and I can't update my anguar cli for this reason. Well what do we need to do for make this possible? How can I help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants