-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues regarding CORSMiddleware #263
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dicas para revisão de códigoCommits
SonarCloud Quality Gate
Build Github actions COM SUCESSOPython
Padrão de URLs para API REST
|
Our devs have reported that CORS seems not to be working after the migration to FastAPI. We find out lots of message at GitHub confirming these issues: fastapi/fastapi#1663 This fix creates a route that handles "OPTIONS" requests and returns the CORS headers: Access-Control-Allow-Origin: * Access-Control-Allow-Methods: POST, GET, DELETE, PATCH, OPTIONS Access-Control-Allow-Headers: Authorization, Content-Type All references to CORSMiddleware were removed.
fberanizo
force-pushed
the
fix/cors-fast-api
branch
from
March 29, 2021 17:11
5de3cae
to
1796090
Compare
SonarCloud Quality Gate failed. |
miguelfferraz
approved these changes
Mar 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our devs have reported that CORS seems not to be working after
the migration to FastAPI.
We find out lots of message at GitHub confirming these issues:
fastapi/fastapi#1663
This fix creates a route that handles "OPTIONS" requests and
returns the CORS headers:
Access-Control-Allow-Origin: *
Access-Control-Allow-Methods: POST, GET, DELETE, PATCH, OPTIONS
Access-Control-Allow-Headers: Authorization, Content-Type
All references to CORSMiddleware were removed.