Fix incorrect use of serverVersion for MariaDB #7
Conversation
This small change fixes 2 things: 1/ Incorrect use of `serverVersion` for MariaDB, which *must* be prefixed with `mariadb-`, see: doctrine/dbal#3083 && symfony/symfony-docs#9547 (and doctrine/dbal#2985 (comment) for the discussion) 2/ `doctrine/dbal` now supports `MariaDB >= 10.2.7`. I added the `.12` as a minor version, but we don't need to update it when platform.sh will use .13 or .14 etc.... as long as it's superior as `10.2.7` (see: https://github.com/doctrine/dbal/blob/f76bf5ef631cec551a86c2291fc749534febebf1/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php#L136)
|
Also. |
|
👍 Sounds like a reasonable first step. We have a plan to expose the server version in the |
|
Mhhhh @damz , I don't know if this is mergeable without detecting first which platform/version is setup on the platform.sh first why ? Because until your merge, the incorrect version would result in using But now, since this patch, it will treat all connection as MariaDB 10.2.x and then if you're using MySQL it may cause problems (like running migrations or other stuff). |
|
@tristanbes It is already documented that this bridge assumes MariaDB 10.2. |
|
See note in README.md:
|
|
ok then, let's hope user will read this note until the correct version/platform gets exposed in env variable |
|
(And we currently only support MariaDB anyway. So the only variability here would be the major version.) |
This small change fixes 2 critical things:
1/ Incorrect use of
serverVersionfor MariaDB, which must be prefixed withmariadb-, see: doctrine/dbal#3083 && symfony/symfony-docs#9547 (and doctrine/dbal#2985 (comment) for the discussion)2/
doctrine/dbalnow supportsMariaDB >= 10.2.7. I added the.12as a minor version, but we don't need to update it when platform.sh will use .13 or .14 etc.... as long as it's superior as10.2.7(see: https://github.com/doctrine/dbal/blob/f76bf5ef631cec551a86c2291fc749534febebf1/lib/Doctrine/DBAL/Driver/AbstractMySQLDriver.php#L136)