-
Notifications
You must be signed in to change notification settings - Fork 161
getting errors while using terminal #293
Comments
I have this exact error as well. OS: Fedora 26 |
Hmm... This does not appear if atom is launched via terminal. Only occurs (for me) if launched from Gnome |
This problem is a user misconfiguration in Fedora, try the solution of @cnicodeme (AtomLinter/linter-flake8#165) For all others that have the same issue here, and are using Fedora, the solution is simple :
|
I'm on Fedora 27, and removed For anyone else who gets here first via Google with additional errors, see this issue comment for the other half of the solution. |
Please retest again with platformio-atom-ide-terminal 2.9.0 is using node-pty-prebuilt instead unmaintained and outdated pty.js |
....Wat? Please review and add structure to the comment above, to increase clarity. |
@alexfornuto see f64888d Its a considerable change in the application, this project no longer uses pty.js, any previous reports are invalid against node-pty-prebuilt version which start at platfomio-ide-terminal v2.9.0. If platfomio-ide-terminal v2.9.0 doesnt fix the issue, a new report with the requested/required information should be opened. If this is not clear enough, state clearly what your doubts are, simply asking for clarity isnt clear enough to what exactly your doubt(s) are. |
@the-j0k3r thanks, that clears up my confusion. For reference, my issue wasn't with the technical decisions made. Your sentence simply lacked the form (punctuation, etc) required to convey the information. Now I understand, and if and when I use Atom again and hit an issue with the newer versions I will open a new issue. |
`getEnvFromShell` function calls `env` command through shell to get all defined environment variable. However `env` also returns the shell function defined with their whole code written on multiple lines. Such shell function definitions were not properly handled by `getEnvFromShell` which led to the following kind of error messages (seen for instance when running a terminal package in Atom): bash: module: line 1: syntax error: unexpected end of file bash: error importing function definition for `BASH_FUNC_module' With this change `getEnvFromShell` now skips shell function definition to guarantee only environment variables are recorded and a sane `result` array is returned. Fixes atom#20389 Fixes atom#17369 Fixes atom#13451 Fixes blueimp/atom-open-terminal-here#27 Fixes blueimp/atom-open-terminal-here#18 Fixes bus-stop/Termination#101 Fixes bus-stop/terminus#24 Fixes platformio/platformio-atom-ide-terminal#120 Fixes platformio/platformio-atom-ide-terminal#293 Fixes AtomLinter/linter-pylint#243 Fixes AtomLinter/linter-flake8#643 Fixes AtomLinter/linter-flake8#165 Fixes AtomLinter/linter-flake8#422 Fixes AtomLinter/linter-puppet-lint#68 Fixes autocomplete-python/autocomplete-python#347
`getEnvFromShell` function calls `env` command through shell to get all defined environment variable. However `env` also returns the shell function defined with their whole code written on multiple lines. Such shell function definitions were not properly handled by `getEnvFromShell` which led to the following kind of error messages (seen for instance when running a terminal package in Atom): bash: module: line 1: syntax error: unexpected end of file bash: error importing function definition for `BASH_FUNC_module' With this change `getEnvFromShell` now skips shell function definition to guarantee only environment variables are recorded and a sane `result` array is returned. Fixes atom#20389 Fixes atom#17369 Fixes atom#13451 Fixes blueimp/atom-open-terminal-here#27 Fixes blueimp/atom-open-terminal-here#18 Fixes bus-stop/Termination#101 Fixes bus-stop/terminus#24 Fixes platformio/platformio-atom-ide-terminal#120 Fixes platformio/platformio-atom-ide-terminal#293 Fixes AtomLinter/linter-pylint#243 Fixes AtomLinter/linter-flake8#643 Fixes AtomLinter/linter-flake8#165 Fixes AtomLinter/linter-flake8#422 Fixes AtomLinter/linter-puppet-lint#68 Fixes autocomplete-python/autocomplete-python#347
when i load terminal it gives me below errors.
OS : FEDORA 26
ATOM : 1.18.0-0.1
The text was updated successfully, but these errors were encountered: