Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update/fix iphone problems #404

Merged
merged 5 commits into from
Mar 18, 2024
Merged

update/fix iphone problems #404

merged 5 commits into from
Mar 18, 2024

Conversation

fabinppkbuilders
Copy link
Contributor

Descrição do PR

Atualização de libs para corrigir problemas ao identificar iPhone 15

Prints

Antes

Captura de Tela 2024-03-15 às 11 49 20

Captura de Tela 2024-03-15 às 11 55 04

Depois

Captura de Tela 2024-03-15 às 11 35 46

Captura de Tela 2024-03-15 às 11 50 25

  • Nova feature (mudança non-breaking que adiciona uma funcionalidade)
  • Bug fix (mudança non-breaking que conserta um problema)
  • Breaking change (ajuste ou funcionalidade que pode causar uma quebra numa funcionalidade já existente)
  • Chore (nenhuma das anteriores, como upgrade de libs)

Checklist 🚨

  • Testado usando Yalc
  • Meu código segue o code style da Builders
  • Meu código foi feito utilizando TDD (testes unitários obrigatórios)

@fabinppkbuilders fabinppkbuilders added bug Something isn't working dependencies Pull requests that update a dependency file labels Mar 15, 2024
@fabinppkbuilders fabinppkbuilders requested a review from a team March 15, 2024 15:55
@fabinppkbuilders fabinppkbuilders self-assigned this Mar 15, 2024
@fabinppkbuilders fabinppkbuilders requested review from caiosantarossa, luancurti and nicolasMolina34 and removed request for a team March 15, 2024 15:55
@fabinppkbuilders
Copy link
Contributor Author

Mesmo sabendo da existência desse comentário, eu estou dando seguimento nas antigas alterações para lidar com o "bottomSpace" e o "statusBarSpace", pois usando a versão 0.10.2 e o hook useSpacingsWithSafeArea não foi possível setar esses espaços corretamente.

Eu obtive o seguinte erro simplesmente ao chamar o hook:

Captura de Tela 2024-03-15 às 14 42 17

Com as alterações desse PR eu consegui validar vários tamanhos de tela de iPhones:

Captura de Tela 2024-03-15 às 14 49 00

@fabinppkbuilders fabinppkbuilders requested a review from a team March 18, 2024 13:29
@fabinppkbuilders fabinppkbuilders merged commit bde5bff into master Mar 18, 2024
2 checks passed
@fabinppkbuilders fabinppkbuilders deleted the fabinppk/update/fix-iphone-problems branch March 18, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdlucas mdlucas mdlucas approved these changes

@caiosantarossa caiosantarossa Awaiting requested review from caiosantarossa caiosantarossa was automatically assigned from platformbuilders/digitals

@luancurti luancurti Awaiting requested review from luancurti luancurti was automatically assigned from platformbuilders/digitals

@nicolasMolina34 nicolasMolina34 Awaiting requested review from nicolasMolina34 nicolasMolina34 was automatically assigned from platformbuilders/digitals

Assignees

@fabinppkbuilders fabinppkbuilders

Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabinppkbuilders @mdlucas @duspada @fabinppk