Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Toggle Button component (resolves #336) #338

Merged
merged 4 commits into from
May 13, 2020
Merged

feat: add Toggle Button component (resolves #336) #338

merged 4 commits into from
May 13, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented May 5, 2020 •
edited
Loading

Description

Adds toggle button and toggle button group components.

  • Default toggle button
  • Inverse toggle button
  • Default toggle button group
  • Inverse toggle button group

Steps to test

Review Toggle Button (Atom) and Toggle Button Group (Molecule).

Additional information

Not applicable.

Related issues

Resolves #336.

@greatislander greatislander added the enhancement New feature or request label May 5, 2020
@greatislander greatislander added this to the 1.0.0-beta.1 milestone May 5, 2020
@greatislander greatislander requested review from jhung and cherylhjli May 5, 2020 21:15
@greatislander greatislander self-assigned this May 5, 2020
@greatislander greatislander added the needs-design This feature depends on designs label May 5, 2020
@netlify
Copy link

netlify bot commented May 5, 2020 •
edited
Loading

Deploy preview for pinecone ready!

Built with commit 5bc4884

https://deploy-preview-338--pinecone.netlify.app

cherylhjli
cherylhjli approved these changes May 5, 2020
View reviewed changes
Copy link

@cherylhjli cherylhjli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Also, I think we accidentally made a strobe light button. :)
toggle button disco ball

@greatislander
Copy link
Collaborator Author

Lol! @cherylhjli can you give me colours for the default (light background) version before I merge this?

@cherylhjli
Copy link

Updated with default colours: https://xd.adobe.com/view/b3e417e8-8969-4cef-4af8-41e1b53d3cae-c5d5/screen/07b2d4a5-b489-4fd6-9e33-f66589d13e76/Web-1280-1/

@greatislander
Copy link
Collaborator Author

@cherylhjli Ready for another review.

@greatislander greatislander requested a review from cherylhjli May 6, 2020 17:27
@greatislander greatislander marked this pull request as ready for review May 6, 2020 17:27
jhung
jhung approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@jhung jhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component is fine. There's a question about adding context for "All" option when implemented.

@greatislander greatislander merged commit b3915e1 into dev May 13, 2020
@greatislander greatislander deleted the add/toggle-buttons branch May 13, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherylhjli cherylhjli cherylhjli approved these changes

@jhung jhung jhung approved these changes

Assignees

@greatislander greatislander

Labels
enhancement New feature or request needs-design This feature depends on designs
Projects
None yet
Milestone
1.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Atom: toggle button
3 participants
@greatislander @cherylhjli @jhung