-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add search bar to menu (resolves #178) #182
Conversation
Deploy preview for pinecone ready! Built with commit 9d6f76c |
It looks great! Is it possible for the search button to be square? It looks a little rectangular right now. |
@cherylhjli Fixed. |
Fixed now — deploying @cherylhjli |
The Search submit button doesn't have a text label, but the dev branch of the Search molecule has a text label. Is this because some changes have not been merged? The span inside the label is also empty, which can be removed since the form has |
Description
Adds a search bar to the menu. On mobile devices, the input is hidden by default but can be revealed by pressing a toggle button. The search input can be hidden by pressing escape, tabbing into the menu, or pressing the toggle button again.
Also resolves #178; an open menu dropdown should be collapsed if another is expanded via click event.
Steps to test
Review menu components (default and home) at all screen sizes.
Additional information
Not applicable.
Related issues