Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add search bar to menu (resolves #178) #182

Merged
merged 10 commits into from
Jan 23, 2020
Merged

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Jan 22, 2020

Description

Adds a search bar to the menu. On mobile devices, the input is hidden by default but can be revealed by pressing a toggle button. The search input can be hidden by pressing escape, tabbing into the menu, or pressing the toggle button again.

Also resolves #178; an open menu dropdown should be collapsed if another is expanded via click event.

Steps to test

Review menu components (default and home) at all screen sizes.

Additional information

Not applicable.

Related issues

@greatislander greatislander self-assigned this Jan 22, 2020
@greatislander greatislander marked this pull request as ready for review January 22, 2020 16:31
@greatislander greatislander added the enhancement New feature or request label Jan 22, 2020
@greatislander greatislander added this to the 1.0.0-alpha.8 milestone Jan 22, 2020
@netlify
Copy link

netlify bot commented Jan 22, 2020

Deploy preview for pinecone ready!

Built with commit 9d6f76c

https://deploy-preview-182--pinecone.netlify.com

@cherylhjli
Copy link

It looks great! Is it possible for the search button to be square? It looks a little rectangular right now.
Also I don't think the home page nav needs a search bar as there's a giant prominent one in the center of the page.

@greatislander
Copy link
Collaborator Author

@cherylhjli Fixed.

@cherylhjli
Copy link

Aspect ratio looks great, it looks like the search bar is still there on the home page though:

Screen Shot 2020-01-23 at 2 38 51 PM

@greatislander
Copy link
Collaborator Author

@greatislander
Copy link
Collaborator Author

Fixed now — deploying @cherylhjli

@jhung
Copy link
Contributor

jhung commented Jan 23, 2020

The Search submit button doesn't have a text label, but the dev branch of the Search molecule has a text label. Is this because some changes have not been merged?

The span inside the label is also empty, which can be removed since the form has role=search already.

@greatislander
Copy link
Collaborator Author

@jhung to clarify, should the label wrapper around the search input be removed altogether? I've fixed the button text in 9d6f76c (I wasn't rendering the search component properly).

@greatislander greatislander changed the title feat: add search bar to menu feat: add search bar to menu (resolves #178) Jan 23, 2020
@greatislander greatislander merged commit 47e5b72 into dev Jan 23, 2020
@greatislander greatislander deleted the add/search-bar branch January 23, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu: opening a dropdown via click event does not close already open dropdowns
3 participants