-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add comprehensive Django support to inputs #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatislander
changed the title
feat: add comprehensive Django support to inputs
feat: BREAKING add comprehensive Django support to inputs
Jun 2, 2020
greatislander
changed the title
feat: BREAKING add comprehensive Django support to inputs
feat!: add comprehensive Django support to inputs
Jun 2, 2020
Deploy preview for pinecone ready! Built with commit f5cae60 |
cherylhjli
approved these changes
Jun 2, 2020
jhung
approved these changes
Jun 2, 2020
This was referenced Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for alternative markup for all form inputs (based on Django conventions).
text
,password
,email
,url
,tel
,number
)Steps to test
Expected behavior: Everything works and looks as expected.
Additional information
Nested checkboxes now require an
.input--parent
class on the parent checkbox. See: https://github.com/platform-coop-toolkit/pinecone/pull/376/files#diff-03a19b9935aa0f00880bc05b3fc94effR47Related issues