Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select box down chevron should match error color #312

Closed
jhung opened this issue Apr 17, 2020 · 1 comment
Closed

Select box down chevron should match error color #312

jhung opened this issue Apr 17, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jhung
Copy link
Contributor

jhung commented Apr 17, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.

If a select box has an error, the down chevron should match the error color. Currently it appears dark, but should be the matching error red color.

image

image

Live example:
https://deploy-preview-288--pinecone.netlify.app/components/detail/selects--default.html

Describe the solution you'd like

The down chevron SVG should match the error color of the select box.

Other notes

I initially tried to solve this using an SVG mask, but could not make the chevron to appear properly. It could be that the SVG mask may not work for Select input elements. More investigation may be needed.
@jhung jhung added enhancement New feature or request good first issue Good for newcomers labels Apr 17, 2020
@jhung jhung mentioned this issue Apr 17, 2020
Closed
@greatislander
Copy link
Collaborator

Fixed in #376.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhung @greatislander