Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise focus and active states for interactive elements #240

Closed
greatislander opened this issue Feb 10, 2020 · 2 comments · Fixed by #288
Closed

Revise focus and active states for interactive elements #240

greatislander opened this issue Feb 10, 2020 · 2 comments · Fixed by #288
Assignees
@jhung
Labels
enhancement New feature or request
Milestone
1.0.0-alpha.14

Comments

@greatislander
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Follow-up to #229 (comment).

Describe the solution you'd like

Implement new link and button focus and active styles as specified in XD state table.

Describe alternatives you've considered

Not applicable.

Additional context

Not applicable.
@greatislander greatislander added the enhancement New feature or request label Feb 10, 2020
@greatislander greatislander added this to the 1.0.0-alpha.11 milestone Feb 10, 2020
@greatislander greatislander added the needs-design This feature depends on designs label Feb 10, 2020
@cherylhjli
Copy link

Updated states table with the newest focus and active states.
Components that have been updated include:

  • All buttons
  • All borderless buttons
  • All disc buttons
  • Tags
  • Links
  • Lists
  • Accordions
  • Pagination
  • Checkboxes
  • Radio buttons

@greatislander greatislander removed the needs-design This feature depends on designs label Feb 13, 2020
@greatislander greatislander mentioned this issue Feb 13, 2020
Merged
2 tasks
@greatislander
Copy link
Collaborator Author

See also: #242 (comment)

This was referenced Mar 24, 2020
Closed
Merged
@greatislander greatislander mentioned this issue Mar 25, 2020
Closed
greatislander pushed a commit that referenced this issue Apr 16, 2020
@jhung
feat: updating form element states to match wires (fixes #240) (#288)
4f20709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhung jhung

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0-alpha.14
Development

Successfully merging a pull request may close this issue.

feat: updating form element states to match wires (fixes #240) jhung/pinecone
3 participants
@jhung @greatislander @cherylhjli