Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review design and implementation of cards and info cards for improved accessibility #190

Closed
jhung opened this issue Jan 23, 2020 · 2 comments · Fixed by #209
Closed

Review design and implementation of cards and info cards for improved accessibility #190

jhung opened this issue Jan 23, 2020 · 2 comments · Fixed by #209
Assignees
Labels
enhancement New feature or request

Comments

@jhung
Copy link
Contributor

jhung commented Jan 23, 2020

Describe the bug
The cards and info-cards are accessible, but not the best accessibility experience. For example, in many cases when a card is focused or read aloud, non-critical information is presented first (like the category or a close button), then the title of the card.

Also each hard has a lot of semantics, some of which may not be critical for a non-visual user. There is an opportunity to simplify and tighten up the semantic information.

To Reproduce
Steps to reproduce the behavior:

  1. Launch a screen reader
  2. Have the screen reader read through resource cards and info-cards.
  3. Notice the complexity of cards (headers, lists, etc.)
  4. Notice the order in which non-critical information is presented to the user first.

Expected behavior
The feedback to the user can be simplified to make it easier to cognitively understand the content. Critical information to the user should be presented first, then non-critical information.

@jhung jhung added enhancement New feature or request needs-design This feature depends on designs labels Jan 23, 2020
@greatislander greatislander added this to the 1.0.0-beta.1 milestone Jan 23, 2020
@cherylhjli
Copy link

cherylhjli commented Jan 28, 2020

Revised designs:

Screen Shot 2020-01-28 at 1 09 34 PM

Screen Shot 2020-01-28 at 1 21 23 PM

Format with all possible metadata

  • Title
  • Author
  • Format [mid dot]. followed by:
    - Publisher, if any resource in the spreadsheet that should show publisher
    - School, if curriculum
    - Conference, if presentation
    - Interviewees, if interview
    (note that I ended up putting these on the same line because I tried it out on separate lines on mobile and the cards can take up an entire screen length or more on a small mobile device)
  • Location
  • Language [mid dot] year published
  • Tags

@dayotte
Copy link

dayotte commented Jan 28, 2020

@cherylhjli these look good. For the case study example I see that the format comes before the author, was that intentional?

@greatislander greatislander removed the needs-design This feature depends on designs label Jan 28, 2020
greatislander pushed a commit that referenced this issue Jan 30, 2020
* feat: improve resource card semantics [WIP]
* fix: pagination indicator regression
* feat: overhaul resource card semantics
* feat: apply new card layout to resource list
* fix: adjust spacing below locality
* feat: improve semantics of other card variants
* fix: align filled favorite icon with unfilled favorite icon
* fix: address SVG padding issue in buttons
* fix: include overflow text in topic list
* feat: add screen reader labels to metadata
* feat: add separator component, use period instead of middot
* fix: adjust separator spacing for NVDA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants