-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "customize feed" button to home page #171
Comments
@cherylhjli Two comments on this:
Thoughts? |
@greatislander the Customize My Feed page has the following description: "Change what kinds of resources you see on your home page" - I think this together with any default selections (i.e. if the My Feed defaults of Most Viewed and Recently Published are selected/checked), I think it would be clear to a screenreader user what is happening. I hope I'm understanding your point correctly. I think having the persistent Customize icon in the main nav is a useful feature. |
I think we are talking about slightly different things, @dayotte. Design is like this: What I'm suggesting is that the order should change. A screen reader user who encounters the "Customize" control before "My feed" might be missing context about what it is that they are customizing. The change I would suggest is moving them inline so that the "Customize" control immediately follows "My feed": The idea is that the title of the section should precede a control within the section. |
I tried that @greatislander, unfortunately on mobile they might very quickly run into each other, especially if it's in a language that tends towards longer words like German. Unless there's a way to make it bump down to the next line if the title is too long? |
In terms of the improper use of a button, we can turn it into a link. |
Definitely can wrap to the next line if needed. |
Great, let's just put it next to each other per your suggestion and wrap to the next line if needed :) |
@cherylhjli There's one other thing we'll need to figure out, which is that our link styles have icons associated with them already, e.g.: https://pinecone.platform.coop/components/detail/link--default.html So I'm concerned this might look a bit off. Thoughts? |
I'm thinking that if we use a link instead of a button for "customize", that we may not need to use the customize icon. What do you think? |
Works for me! |
Is your feature request related to a problem? Please describe.
Adding the CTA to access the customize feed page.
Describe the solution you'd like
A borderless button with a "customize" icon, found in the icon_v02 folder.
Additional context
See Core screens v02 CL on the cloud for precise specs.
The text was updated successfully, but these errors were encountered: