Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "customize feed" button to home page #171

Closed
cherylhjli opened this issue Jan 20, 2020 · 10 comments · Fixed by #191
Closed

Add "customize feed" button to home page #171

cherylhjli opened this issue Jan 20, 2020 · 10 comments · Fixed by #191
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cherylhjli
Copy link

Is your feature request related to a problem? Please describe.

Adding the CTA to access the customize feed page.

Describe the solution you'd like

A borderless button with a "customize" icon, found in the icon_v02 folder.

Additional context

See Core screens v02 CL on the cloud for precise specs.

@cherylhjli cherylhjli added the enhancement New feature or request label Jan 20, 2020
@greatislander greatislander added this to the 1.0.0-alpha.8 milestone Jan 20, 2020
@greatislander greatislander self-assigned this Jan 20, 2020
@greatislander
Copy link
Collaborator

@cherylhjli Two comments on this:

  1. The order of the elements on this design is not intuitive; a screen reader user would encounter the "Customize" control before the "My Feed". I'd argue that "Customize" should be after "My Feed" to make sure that the context is clear.

  2. A button is not appropriate for this; it's a link to another page, not a button that invokes an action on the current page. I'd suggest a straightforward link instead.

Thoughts?

CC: @dayotte @jhung

@dayotte
Copy link

dayotte commented Jan 21, 2020

@greatislander the Customize My Feed page has the following description: "Change what kinds of resources you see on your home page" - I think this together with any default selections (i.e. if the My Feed defaults of Most Viewed and Recently Published are selected/checked), I think it would be clear to a screenreader user what is happening. I hope I'm understanding your point correctly. I think having the persistent Customize icon in the main nav is a useful feature.

@greatislander
Copy link
Collaborator

greatislander commented Jan 21, 2020

I think we are talking about slightly different things, @dayotte.

Design is like this:

Customize preceding My Feed

What I'm suggesting is that the order should change. A screen reader user who encounters the "Customize" control before "My feed" might be missing context about what it is that they are customizing.

The change I would suggest is moving them inline so that the "Customize" control immediately follows "My feed":

Customize following My Feed

The idea is that the title of the section should precede a control within the section.

@cherylhjli
Copy link
Author

I tried that @greatislander, unfortunately on mobile they might very quickly run into each other, especially if it's in a language that tends towards longer words like German.
This is not running into each other, but you can imagine there are many languages we can't predict:
Screen Shot 2020-01-21 at 6 08 33 PM

Unless there's a way to make it bump down to the next line if the title is too long?

here are some other explorations:
Screen Shot 2020-01-21 at 6 08 49 PM
Screen Shot 2020-01-21 at 6 09 09 PM

@cherylhjli
Copy link
Author

In terms of the improper use of a button, we can turn it into a link.

@greatislander
Copy link
Collaborator

Definitely can wrap to the next line if needed.

@cherylhjli
Copy link
Author

Great, let's just put it next to each other per your suggestion and wrap to the next line if needed :)

@greatislander
Copy link
Collaborator

@cherylhjli There's one other thing we'll need to figure out, which is that our link styles have icons associated with them already, e.g.: https://pinecone.platform.coop/components/detail/link--default.html

So I'm concerned this might look a bit off. Thoughts?

@cherylhjli
Copy link
Author

I'm thinking that if we use a link instead of a button for "customize", that we may not need to use the customize icon. What do you think?

@greatislander
Copy link
Collaborator

Works for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants