fix: don't defer Pinecone bundle

platform-coop-toolkit · Feb 20, 2020 · 1c8b7cf · 1c8b7cf
1 parent 867b3a5
commit 1c8b7cf
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/components/_preview.njk b/src/components/_preview.njk
@@ -5,7 +5,7 @@
 		<meta http-equiv="x-ua-compatible" content="ie=edge">
 		<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
 		<script>(function(html){html.className = html.className.replace(/\bno-js\b/,'js')})(document.documentElement);</script>
-		<script src="{{ '/scripts/pinecone.umd.js' | path }}" defer></script>
+		<script src="{{ '/scripts/pinecone.umd.js' | path }}"></script>
 		<script src="{{ '/scripts/pinecone.js' | path }}" defer></script>
 		<link rel="stylesheet" href="{{ '/styles/pinecone.css' | path }}">
 		<link rel="apple-touch-icon" sizes="180x180" href="{{ '/images/apple-touch-icon.png' | path }}">

diff --git a/src/components/layouts/search-results/search-results.njk b/src/components/layouts/search-results/search-results.njk
@@ -49,10 +49,10 @@
 </ul>
 </div>
 {% render '@pagination', {title: false}, true %}
-<script>
+<script defer>
 	const dialogBtn = document.getElementById( 'save-search' );
 	if ( dialogBtn ) {
-		new window.Pinecone.Dialog( dialogBtn, {
+		new Pinecone.Dialog( dialogBtn, {
 			title: "{{ dialogTitle | safe }}",
 			question: "{{ dialogQuestion | safe }}",
 			input: "{{ dialogInput }}",

diff --git a/src/components/molecules/dialog/dialog.njk b/src/components/molecules/dialog/dialog.njk
@@ -1,9 +1,9 @@
 {% if not standAlone %}<div class="spacer"></div>{% endif %}
 {% render '@button--borderless', {label: buttonLabel, id: 'invoke-dialog', icon: buttonIcon, iconPosition: 'start', standAlone: true}, true %}
-<script>
+<script defer>
 	const dialogBtn = document.getElementById( 'invoke-dialog' );
 	if ( dialogBtn ) {
-		new window.Pinecone.Dialog( dialogBtn, {
+		new Pinecone.Dialog( dialogBtn, {
 			title: "{{ dialogTitle | safe }}",
 			question: "{{ dialogQuestion | safe }}",
 			{% if dialogInput %}