Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invert analytics settings #374

Merged
merged 1 commit into from
Sep 4, 2020
Merged

fix: invert analytics settings #374

merged 1 commit into from
Sep 4, 2020

Conversation

greatislander
Copy link
Collaborator

Description

This PR defaults to allowing analytics to be collected. It's possible that the previous default was preventing some visits from being recorded.

Steps to test

  1. Clear cookies
  2. Visit settings page.

Expected behavior: Allow tracking is enabled by default.

Additional information

Not applicable.

Related issues

Not applicable.

@greatislander greatislander self-assigned this Sep 4, 2020
@greatislander greatislander added the enhancement New feature or request label Sep 4, 2020
@greatislander greatislander added this to the 1.0.0-rc.2 milestone Sep 4, 2020
@greatislander greatislander merged commit 231b489 into dev Sep 4, 2020
@greatislander greatislander deleted the fix/analytics branch September 4, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant