feat: update Pinecone to alpha 14 #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhung another TODO: we should switch the brand icon to the new library logo. |
greatislander
requested changes
Apr 20, 2020
There was a problem hiding this comment.
@jhung can you run npm i and commit the updated package-lock.json file? I should be able to install using npm ci but it says the lockfile version doesn't match what's in package.json.
EDIT: Resolve merge conflicts while you're at it?
|
@greatislander I updated the PR description to include instructions for building the global navigation menu. This should be included in the setup somehow? |
greatislander
requested changes
Apr 20, 2020
greatislander
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Pinecone version to Alpha 14, updated branding, added global navigation
To add global navigation, in the dashboard, add a new menu "Global Navigation" with a link to https://platform.coop/ as the first menu item, and a link to the Front Page as the second item. In menu locations, add this new "Global Navigation" menu to the Global Navigation location.
Steps to test
npm iExpected behavior:
Nothing should look broken.
Additional information
There are some known issues which have been filed already in Pinecone.
https://github.com/platform-coop-toolkit/pinecone/issues