Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: language filtering (resolves #237) #244

Merged
merged 4 commits into from
Mar 31, 2020
Merged

Conversation

greatislander
Copy link
Collaborator

Description

This PR fixes a conflict between resource language filtering and Polylang. Resources should now be properly filterable by languag

Steps to test

  1. Visit the Browse all page in various languages.
  2. Filter resources by language.

Expected behavior: Visiting the resource page in non-English languages should no longer present a default filter with the language applied. Resources should be properly filterable by resource language.

Additional information

Not applicable.

Related issues

@greatislander greatislander added the enhancement New feature or request label Mar 30, 2020
@greatislander greatislander added this to the 1.0.0-rc.1 milestone Mar 30, 2020
@greatislander greatislander requested a review from jhung March 30, 2020 22:55
@greatislander greatislander self-assigned this Mar 30, 2020
@greatislander greatislander merged commit cf2b939 into dev Mar 31, 2020
@greatislander greatislander deleted the fix/language-filter branch March 31, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix language filtering
2 participants