Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add language switcher and brand; update filter list #142

Merged
merged 10 commits into from
Jan 16, 2020
Merged

feat: add language switcher and brand; update filter list #142

merged 10 commits into from
Jan 16, 2020

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Jan 15, 2020 •
edited
Loading

Description

Steps to test

  • Test language switcher. Verify that current language is displayed.
  • Verify that banner brand displays as expected.
  • Verify that nested checkbox disclosure (including accessible labels) work as expected.

Additional information

Not applicable.

Related issues

@greatislander greatislander self-assigned this Jan 15, 2020
@greatislander greatislander added the enhancement New feature or request label Jan 15, 2020
@greatislander greatislander added this to the 1.0.0-alpha.1 milestone Jan 15, 2020
@greatislander greatislander marked this pull request as ready for review January 16, 2020 17:40
@greatislander greatislander requested a review from jhung January 16, 2020 17:40
@greatislander greatislander changed the title feat: add language switcher to menu feat: add language switcher and brand Jan 16, 2020
@greatislander greatislander changed the title feat: add language switcher and brand feat: add language switcher and brand; update filter list disclosure buttons Jan 16, 2020
@greatislander greatislander changed the title feat: add language switcher and brand; update filter list disclosure buttons feat: add language switcher and brand; update filter list Jan 16, 2020
@greatislander greatislander merged commit 44982e4 into dev Jan 16, 2020
@greatislander greatislander deleted the add/language-switcher branch January 16, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhung jhung Awaiting requested review from jhung

Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0-alpha.1
Development

Successfully merging this pull request may close these issues.
1 participant
@greatislander