Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement nested terms in filter UI (resolve #139) #140

Merged
merged 1 commit into from
Jan 15, 2020
Merged

feat: implement nested terms in filter UI (resolve #139) #140

merged 1 commit into from
Jan 15, 2020

Conversation

greatislander
Copy link
Collaborator

Description

This PR properly displays nested terms in the filter list.

Steps to test

  1. Ensure that some parent/child relationships exist in the list of topics (for example, set the parent topic of "Governance" and "Ownership" to a topic called "Cooperative essentials").
  2. Navigate to the Resource list.

Expected behavior: Child terms appear as sub-terms of parent term, as seen here.

Additional information

Not applicable.

Related issues

@greatislander greatislander requested a review from jhung January 15, 2020 18:57
@greatislander greatislander self-assigned this Jan 15, 2020
@greatislander greatislander added the enhancement New feature or request label Jan 15, 2020
@greatislander greatislander added this to the 1.0.0-alpha.1 milestone Jan 15, 2020
@greatislander greatislander merged commit 5a7eb34 into dev Jan 15, 2020
@greatislander greatislander deleted the add/nested-filter-support branch January 15, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhung jhung jhung approved these changes

Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0-alpha.1
Development

Successfully merging this pull request may close these issues.

Add support for nested topics in filter UI
2 participants
@greatislander @jhung