Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: provide context for resource format label (resolves #136) #137

Merged
merged 2 commits into from
Jan 15, 2020
Merged

fix: provide context for resource format label (resolves #136) #137

merged 2 commits into from
Jan 15, 2020

Conversation

greatislander
Copy link
Collaborator

Description

Resolve #136 by adding visually hidden prefix to resource format.

Steps to test

  1. Visit single resource and examine content using a screen reader.

Expected behavior: Format label is read out as "resource format: academic article" (or whatever the format is).

Additional information

Not applicable.

Related issues

@greatislander greatislander self-assigned this Jan 14, 2020
@greatislander greatislander requested a review from jhung January 14, 2020 21:48
@greatislander greatislander added the enhancement New feature or request label Jan 14, 2020
@greatislander greatislander added this to the 1.0.0-alpha.1 milestone Jan 14, 2020
@greatislander greatislander changed the title fix: provide context for resource format to AT users (resolves #136) fix: provide context for resource format label (resolves #136) Jan 14, 2020
jhung
jhung requested changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@jhung jhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually fixes a related issue, but not the one mentioned in Issue #136 . Issue #136 is the lack of context in a single resource view, not the listing.

image

@greatislander
Copy link
Collaborator Author

@jhung Good catch. Applied this change to single resource view as well.

@greatislander greatislander requested a review from jhung January 15, 2020 20:00
@greatislander greatislander merged commit 340d063 into dev Jan 15, 2020
@greatislander greatislander deleted the fix/resource-format-context branch January 15, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhung jhung jhung approved these changes

Assignees

@greatislander greatislander

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0-alpha.1
Development

Successfully merging this pull request may close these issues.

In resource view the resource category lacks context for a screen reader
2 participants
@greatislander @jhung